Repository navigation
ext/zip: Reject broken libzip versions on Windows - #24371
Merged
Merged
Conversation
Member
|
I have no objections, but please wait for the other RMs. |
Merged
shivammathur
approved these changes
Oct 23, 2026
Contributor
|
I like that libzip fixed their regression, but this doesn't feel like it warrants being bundled into a |
LamentXU123
force-pushed
the
zip-windows-version-check
branch
from
October 25, 2026 05:58
d445d38 to
2823c30
Compare
LamentXU123
force-pushed
the
zip-windows-version-check
branch
from
October 25, 2026 16:26
2823c30 to
b107dce
Compare
LamentXU123
added a commit
that referenced
this pull request
Oct 25, 2026
* PHP-8.6: Merge branch 'PHP-8.5' into PHP-8.6 Merge branch 'PHP-8.4' into PHP-8.5 ext/zip: Reject broken libzip versions on Windows (#24371)
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-php__php-src
that referenced
this pull request
Oct 25, 2026
* PHP-8.4: ext/zip: Reject broken libzip versions on Windows (php#24371)
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-php__php-src
that referenced
this pull request
Oct 25, 2026
* PHP-8.5: Merge branch 'PHP-8.4' into PHP-8.5 ext/zip: Reject broken libzip versions on Windows (php#24371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six years ago in f3e6b12 we reject them in .m4 but sadly forget to reject them in .w32