streams: add so_rcvbuf and so_sndbuf socket context options. - #23406
Closed
devnexen wants to merge 3 commits into
Closed
streams: add so_rcvbuf and so_sndbuf socket context options.#23406devnexen wants to merge 3 commits into
devnexen wants to merge 3 commits into
Conversation
NickSdot
reviewed
Aug 22, 2026
Comment on lines
+11
to
+23
| } catch (ValueError $e) { | ||
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| $context = stream_context_create(['socket' => ['so_rcvbuf' => 0]]); | ||
| try { | ||
| @stream_socket_client("tcp://127.0.0.1:1", $errno, $errstr, 1, | ||
| STREAM_CLIENT_CONNECT, $context); | ||
| } catch (ValueError $e) { | ||
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (ValueError $e) { | |
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; | |
| } | |
| } | |
| } | |
| $context = stream_context_create(['socket' => ['so_rcvbuf' => 0]]); | |
| try { | |
| @stream_socket_client("tcp://127.0.0.1:1", $errno, $errstr, 1, | |
| STREAM_CLIENT_CONNECT, $context); | |
| } catch (ValueError $e) { | |
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; | |
| } | |
| } catch (Throwable $e) { | |
| echo $e::class, ': ', $e->getMessage(), "\n"; | |
| } | |
| } | |
| } | |
| $context = stream_context_create(['socket' => ['so_rcvbuf' => 0]]); | |
| try { | |
| @stream_socket_client("tcp://127.0.0.1:1", $errno, $errstr, 1, | |
| STREAM_CLIENT_CONNECT, $context); | |
| } catch (Throwable $e) { | |
| echo $e::class, ': ', $e->getMessage(), "\n"; | |
| } |
Member
Author
There was a problem hiding this comment.
sure once I get a review I ll do all in one swoop.
bukka
requested changes
Sep 4, 2026
They set SO_RCVBUF and SO_SNDBUF in bytes on TCP and UDP sockets, applied before connect() and listen(). Values outside 1 to INT_MAX throw a ValueError.
devnexen
force-pushed
the
stream_stf_so_buf
branch
from
September 4, 2026 21:47
eb78641 to
83ad243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They set SO_RCVBUF and SO_SNDBUF in bytes on TCP and UDP sockets, applied before connect() and listen(). Values outside 1 to INT_MAX throw a ValueError.