ext/spl: SplDoublyLinkedList::serialize() use-after-free on element r… - #23388
Closed
devnexen wants to merge 1 commit into
Closed
ext/spl: SplDoublyLinkedList::serialize() use-after-free on element r…#23388devnexen wants to merge 1 commit into
devnexen wants to merge 1 commit into
Conversation
…emoval. Fix php#23385 The serialization loop passed php_var_serialize() a pointer into the list element itself, so a userland __serialize() unsetting that entry freed both the element and its payload while the serializer was still walking them. Serialize a copy of the element data instead, which outlives the callback.
Member
Member
Author
|
I saw it but I assigned it to myself prior but also his fix is not correct (spl part at least). |
ndossche
approved these changes
Sep 11, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
A bit unfortunate, re-entrancy is always annoying in PHP, but it is what it is...
Fix is fine. Please deal with closing the other PR upon merging, thx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…emoval.
Fix #23385
The serialization loop passed php_var_serialize() a pointer into the list element itself, so a userland __serialize() unsetting that entry freed both the element and its payload while the serializer was still walking them. Serialize a copy of the element data instead, which outlives the callback.