[Sync-EN] Fix the SplFixedArray non-integer key example - #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
reference/spl/splfixedarray.xmlwith php/doc-en#5227 and php/doc-en#5699.php/doc-en#5227:
RuntimeException. As of PHP 8.1.0 it throws aTypeError, so that case is moved to the end of the example, caught asTypeError, with a comment about the pre-8.1.0 behaviour, and the expected output ends withTypeError: Illegal offset type.php/doc-en#5699: mirrors the removal of the two empty
xi:fallbackelements in the class synopsis.EN-Revision bumped to a833060594749e44ff296fee01fd587d6395cff7, which covers both upstream commits.
Fixes: #1711