[Sync-En] ext/mbstring: clarify the ValueError conditions of mb_*code_numericentity - #1220
Open
lacatoire wants to merge 1 commit into
Open
[Sync-En] ext/mbstring: clarify the ValueError conditions of mb_*code_numericentity#1220lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
lacatoire
force-pushed
the
sync-en/1206-mbstring-numericentity
branch
from
September 3, 2026 11:41
124e063 to
0ec948b
Compare
lacatoire
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation of php/doc-en#4852 (commit 3505aae): the errors section and the 8.4.0 changelog entry of mb_decode_numericentity and mb_encode_numericentity now say that map may hold any value implicitly convertible to int, not only integers.
Both pages also pick up php/doc-en#4708 (commit 0bb8d1a), the code style pass on the examples: it is the later commit on these two files, so it is the hash EN-Revision has to declare.
Fixes: #1206