Repository navigation
Conversation
yoeunes
force-pushed
the
walk-the-phpregex-ast
branch
2 times, most recently
from
October 23, 2026 18:29
40a0270 to
c3b490f
Compare
yoeunes
force-pushed
the
judge-pattern-validity-for-the-analysed-engine
branch
from
October 23, 2026 18:37
570449f to
9952049
Compare
The pre-check that gated unreadable patterns compiled them on the
running engine, so a construct the runner takes but the analysed PHP
predates kept its shapes — a padded \x{ 41 } on a project pinned to
PHP 8.2 read as the letter x then text instead of carrying no shape at
all. The reader validates for the target it reads for, the engine that
answers is the one the project runs, and the invalid-pattern rule keeps
speaking for the running engine as it always did — each part of the
pipeline names its own judge.
yoeunes
force-pushed
the
walk-the-phpregex-ast
branch
from
October 23, 2026 19:43
c3b490f to
fe67a32
Compare
yoeunes
force-pushed
the
judge-pattern-validity-for-the-analysed-engine
branch
from
October 23, 2026 19:45
9952049 to
9cfff24
Compare
Member
Author
|
Folded into #1: the stack now travels as one pull request while the series is being built. The branch content is unchanged — read-regex-shapes-through-phpregex points at the same commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1 and #2 — review those first.
What
The pre-check that gated unreadable patterns compiled them on the running engine. A construct the runner takes but the analysed PHP predates kept its shapes: a padded
\x{ 41 }on a project analysed for PHP 8.2 (PCRE2 10.40) read as the letter x then text, when the engine that project actually runs refuses the pattern outright.The reader now validates for the target it reads for —
PHPRegexReader::accepts()— so:array<string>), whatever the runner thinks;RegularExpressionPatternRulekeeps reporting on the running engine, as it always did — each part of the pipeline names its own judge.This closes the open point recorded in #1's review notes.
Test plan
nullshape for PHP 8.2, non-constant shape for 8.4