Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #445
Adds an HTTP layer section to the README (under Extending Embed):
Crawler,CurlClientandCurlDispatcherfit together, and whyCurlDispatcherisfinaland not configurable with rawCURLOPT_*options in v4.CURLOPT_*option to its v4CurlClientsetting, with defaults taken from the code.Crawler::addDefaultHeaders().CurlClientin a PSR-18 decorator instead of extending the dispatcher, and what changes then (getMulti()is sequential, the URL policy does not reach the inner client).The examples were run against v4.6.0 and work.
Docs only, no code changes. CHANGELOG has a
[4.6.2]section on top of 4.6.0. This should be merged after #589 (4.6.1); the CHANGELOG will then need a trivial merge from master.