Repository navigation
Add mastodon:iframe setting to embed Mastodon posts as an iframe - #586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mastodon's oEmbed (
/api/oembed, already used by Embed) returns a<blockquote class="mastodon-embed" data-embed-url=".../embed">plus<script src=".../embed.js">. Sites that strip scripts end up with a "View on Mastodon" link instead of the post.This adds an opt-in
mastodon:iframesetting (defaultfalse). When enabled, that html is replaced with:data-embed-urlishttps, ends in/embedand is on the same host as the requested post. Otherwise the original html is kept.nullbecause Mastodon does not report one.Tests
fosstodon.org/@AkaSci/117514634840174369,hachyderm.io/@briancmoses/117514657412674435(default output, blockquote).tests/MastodonIframeTest.php: the same recorded responses with and without the setting, plus a cross-host embed URL, a non-https embed URL and non-Mastodon html.Not confirmed
embed.jsthe iframe does not resize, so the README tells users to set a height in CSS.Note: the CHANGELOG entry is 4.6.0; if #585 (4.5.3) merges first, the compare links may need a rebase.