Repository navigation
CI: test PHP 8.5, add 8.6 nightly and lowest deps, harden workflow - #583
Merged
Merged
Conversation
- Add PHP 8.5 to the matrix and run PHPStan on 8.5 - Add a PHP 8.6 nightly job that is allowed to fail - Use ramsey/composer-install instead of caching vendor - Test lowest dependencies on PHP 7.4 - Add fail-fast false, read-only permissions, concurrency, workflow_dispatch and composer validate --strict - Require oscarotero/html-parser ^0.1.6 (0.1.4 and 0.1.5 fail tests) - Point homepage and support links to php-embed/Embed
Vitorinox
force-pushed
the
ci/php-8.5-and-improvements
branch
from
October 27, 2026 19:56
6eb4f09 to
094ffd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the GitHub Actions workflow and fixes a few things found while doing it.
Changes
.github/workflows/test.ymlcontinue-on-error: true, so upcoming breakages (for example theml/json-lddeprecations tracked in PHP 8.5 deprecations from ml/json-ld (tracking, see #554) #582) show up early without blocking PRs. Composer runs with--ignore-platform-req=php+there.fail-fast: false, so one failing PHP version no longer cancels the others.ramsey/composer-install@v4replaces theactions/cacheofvendor. The old cache was keyed oncomposer.jsononly (there is nocomposer.lock), so it could reuse stale dependencies. The action caches Composer's download cache properly.dependency-versions: lowest), highest everywhere else, to catch constraint problems such aspsr/http-message1 vs 2.permissions: contents: read, aconcurrencygroup that cancels outdated runs on PRs,workflow_dispatchfor manual runs, and acomposer validate --strictstep.EMBED_STRICT_CACHE: 1is kept on the test step.coverage: nonespeeds up setup-php.composer.jsonoscarotero/html-parserraised from^0.1.4to^0.1.6. The new lowest-deps job showed that 0.1.4 and 0.1.5 fail two page fixtures (itmedia.co.jp and 4pda.to, wrong title and description extraction for non-ASCII pages). 0.1.6 and later pass.homepageandsupport.issuesnow point to php-embed/Embed, andsupport.sourcewas added. Author info is unchanged.Local results (macOS, Homebrew PHP)
composer validate --strict: validactionlint: no issuesCurlClientTest::testInternationalizedHostIsPinnedInPunycode) errors locally; this looks specific to the Homebrew php@8.0 build (intl loaded as a separate extension), and the code under test is unchanged by this PR. CI will confirm.--prefer-loweston PHP 7.4: OK (237 tests) after the html-parser bump, 2 failures before it.