Repository navigation
Change provider name from 'Music on TIDAL' to 'TIDAL' - #568
Closed
DieterHolvoet wants to merge 2 commits into
Closed
DieterHolvoet wants to merge 2 commits into
DieterHolvoet wants to merge 2 commits into
Conversation
Collaborator
|
Thanks a lot for this, @DieterHolvoet, and sorry for the long wait. I tested it on top of current master (PHP 8.5, all 237 tests pass) against a real TIDAL playlist. It turns out TIDAL changed its response since December: the provider name now comes back as "TIDAL", and its oEmbed endpoint returns the playlist iframe directly. Current master already produces the same provider name and embed code as this branch, so the custom adapter and the fallback are no longer needed. I'm closing this for that reason, but feel free to open a new PR if you find a TIDAL URL (album, track, video) that still doesn't embed correctly. Thanks again for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.