document the report_xdebug_module setting - #22
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
php_debugger.report_xdebug_module, which was missing from the settings page.It controls whether
extension_loaded("xdebug")reportstrue. Off by default because some tools — Composer and PHPUnit among them — use that check to detect Xdebug and then restart PHP with the extension disabled, a restart that cannot work here since there is no separate Zend extension to unload. Worth turning on only for a tool that gates a feature on the check rather than trying to disable anything.Why it was missed: the previous page was verified against
origin/main, which in this checkout is thecarlos-granados/php-debuggerfork, notphp-debugger/php-debugger. The canonical repo is theupstreamremote and it was ahead — the fork's main sits at #95, upstream at 0.3.2 including #108, which added this setting. Re-diffed againstupstream/main.After this, every setting registered on
upstream/mainis documented exceptmax_nesting_level, which is still read nowhere insrc/and so is left out under the same rule as the other inert settings.