Repository navigation
Allow goaop/framework 5.x - #75
Merged
Merged
Conversation
Go! AOP 5 is the 4.x line for PHP 8.5+ with the same API, so the constraint becomes ^4.0 || ^5.0 and Composer picks the version that fits the PHP version. The whole suite (style, PHPStan, tests, demo) passes against 5.x-dev. CI gets a PHP 8.5 job that requires goaop/framework 5.x-dev until 5.0.0 is tagged. README, CHANGELOG, UPGRADE-2.0 and AGENTS.md mention both versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
lisachenko
marked this pull request as ready for review
November 10, 2026 21:22
lisachenko
commented
Nov 10, 2026
`^5.0@dev` lets the PHP 8.5 jobs pick 5.x-dev until 5.0.0 is tagged and then the stable release, without a dedicated matrix entry. The flag only affects this repository's own installs: Composer ignores stability flags of dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
lisachenko
commented
Nov 10, 2026
The PHP 8.6 job may fail without failing the build and ignores the upper PHP bounds of dependencies. AGENTS.md and the changelog no longer name Go! AOP versions: composer.json decides them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goaop/frameworkconstraint becomes^4.0 || ^5.0@dev. Go! AOP 5 is the 4.x line for PHP 8.5+ with the same API, so no source change is needed. Composer installs 4.x on PHP 8.4 and 5.x on PHP 8.5.@devlets this repository's PHP 8.5 jobs run against 5.x-dev until 5.0.0 is tagged;^5.0also matches 5.0.0 once it ships. Downstream projects are not affected, because Composer ignores stability flags of dependencies. Side effect: the PHP 8.4 "highest" job installs4.x-dev. The "lowest" job still covers 4.0.0.continue-on-error,--ignore-platform-req=php+).^4.0 || ^5.0.Testing
composer test(PHP-CS-Fixer, PHPStan level 10, 168 tests) andcomposer demopass on PHP 8.5 with goaop 4.0.0 and with goaop 5.x-dev (6470d6e).composer validate --strictpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV