Skip to content

Allow goaop/framework 5.x - #75

Merged
lisachenko merged 5 commits into
masterfrom
feature/zealous-goodall-0525px
Nov 10, 2026
Merged

lisachenko merged 5 commits into
masterfrom
feature/zealous-goodall-0525px

Conversation

@lisachenko

@lisachenko lisachenko commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Summary

  • goaop/framework constraint becomes ^4.0 || ^5.0@dev. Go! AOP 5 is the 4.x line for PHP 8.5+ with the same API, so no source change is needed. Composer installs 4.x on PHP 8.4 and 5.x on PHP 8.5.
  • @dev lets this repository's PHP 8.5 jobs run against 5.x-dev until 5.0.0 is tagged; ^5.0 also matches 5.0.0 once it ships. Downstream projects are not affected, because Composer ignores stability flags of dependencies. Side effect: the PHP 8.4 "highest" job installs 4.x-dev. The "lowest" job still covers 4.0.0.
  • CI: PHP 8.4 and 8.5 as before, plus a new experimental PHP 8.6 job (continue-on-error, --ignore-platform-req=php+).
  • Docs: the README (setup section and badge), AGENTS.md and the CHANGELOG name no Go! AOP versions. Only the UPGRADE-2.0 requirements table lists ^4.0 || ^5.0.

Testing

  • composer test (PHP-CS-Fixer, PHPStan level 10, 168 tests) and composer demo pass on PHP 8.5 with goaop 4.0.0 and with goaop 5.x-dev (6470d6e).
  • composer validate --strict passes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV

Go! AOP 5 is the 4.x line for PHP 8.5+ with the same API, so the constraint
becomes ^4.0 || ^5.0 and Composer picks the version that fits the PHP version.
The whole suite (style, PHPStan, tests, demo) passes against 5.x-dev.

CI gets a PHP 8.5 job that requires goaop/framework 5.x-dev until 5.0.0 is
tagged. README, CHANGELOG, UPGRADE-2.0 and AGENTS.md mention both versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
@lisachenko
lisachenko marked this pull request as ready for review November 10, 2026 21:22
Comment thread .github/workflows/ci.yml Resolved
`^5.0@dev` lets the PHP 8.5 jobs pick 5.x-dev until 5.0.0 is tagged and
then the stable release, without a dedicated matrix entry. The flag only
affects this repository's own installs: Composer ignores stability flags
of dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
Comment thread .github/workflows/ci.yml Resolved
Comment thread AGENTS.md Resolved
Comment thread CHANGELOG.md Resolved
Comment thread README.md Resolved
The PHP 8.6 job may fail without failing the build and ignores the upper
PHP bounds of dependencies. AGENTS.md and the changelog no longer name
Go! AOP versions: composer.json decides them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxhC1Cr7rZzUgw16qS4vNV
@lisachenko
lisachenko merged commit 15b6c16 into master Nov 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants