Fix root id-change patch corruption - #4335
Closed
lukaszsamson wants to merge 1 commit into
Closed
Conversation
Member
|
Thank you @lukaszsamson. I think the original fix for #3423 is actually wrong and this should be handled in morphdom instead, see patrick-steele-idem/morphdom#290. I opened #4338. |
zekedou
pushed a commit
to plastic-forks/phoenix_live_view
that referenced
this pull request
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code returned the result of
onNodeAddedwhich isundefined. Morphdom aborts an element morph only whenonBeforeElUpdatedreturns strictlyfalsehttps://github.com/patrick-steele-idem/morphdom/blob/8e004ca546b428dbe5a5e34a78b8af6179f85013/src/morphdom.js#L219-L222
It continued with attribute and child morphing using:
fromEl- the detached old roottoEl- the visible replacement rootThis PR changes it to recursively apply
onNodeAddedfor the replacement and its children. It also explicitly returnsfalseto stop morphdom from processing the detached old rootScreen.Recording.2026-07-22.at.11.17.46.mov
Fixes #4334