Skip to content

[Restore] Reintroduce SSH connections and ACP support - #25

Draft
phinaldoo wants to merge 1 commit into
mainfrom
restore-ssh-acp-support
Draft

phinaldoo wants to merge 1 commit into
mainfrom
restore-ssh-acp-support

Conversation

@phinaldoo

Copy link
Copy Markdown
Owner

Ported from phinaldoo/chatui#1006 and adapted to Omlorix's current repository layout and branding.

Purpose

This draft preserves SSH connections and ACP support so they can be restored and developed later.

Contents

  • restores the complete SSH connection backend, transport, terminal UI, persistence, policy, and import/export integration
  • restores the complete ACP provider/runtime/session/permission stack and frontend workflow
  • restores related schema, dependencies, translations, tests, documentation, and vendored xterm assets

Relationship to the source removal PR

The source PR was stacked on remove-ssh-acp-support. Omlorix main already omits this functionality, so this adapted restoration targets main directly.

Porting note

The implementation was adapted to Omlorix's refactored chat, split-screen, admin, and provider modules and to current Omlorix branding. The source repository's removed data-governance subsystem was not reintroduced.

Port validation

  • node --test frontend/js/chat/acpModelSelect.test.js frontend/js/chat/splitScreen.acp.test.js frontend/js/chat/sshTerminal.test.js frontend/js/chat/workspaceRemoteConnections.test.js frontend/js/chat/workspaceConnections.test.js frontend/js/chat/workspaceCreateEditForms.test.js frontend/js/chat/workspaceConnectionPolicy.test.js — 65 passed
  • Python compilation passed for changed Python files.
  • node --check passed for changed JavaScript files.
  • Locale JSON validation and git diff --check passed.
  • Backend pytest was not available in the isolated porting environment.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This reverts commit 5b93b52446dd432cb9d9d9e70e65d3fc077fde08.
@phinaldoo
phinaldoo force-pushed the restore-ssh-acp-support branch from 0494467 to e626b0f Compare September 12, 2026 09:40
with tempfile.TemporaryDirectory(prefix="omlorix-ssh-") as directory:
key_path = Path(directory) / "identity"
known_hosts_path = Path(directory) / "known_hosts"
key_path.write_text(private_key + "\n", encoding="utf-8")
"USER_ACP_PROFILE_TEST_FAILED",
{"profile_id": profile.id},
)
return {"state": "error", "detail": str(exc)[:1000]}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants