Skip to content

improved on script with aria2c - #93

Merged
philipmat merged 3 commits into
philipmat:masterfrom
albertfougy:albert_dev
Mar 30, 2019
Merged

improved on script with aria2c#93
philipmat merged 3 commits into
philipmat:masterfrom
albertfougy:albert_dev

Conversation

@albertfougy

Copy link
Copy Markdown
Contributor

Screen Shot 2019-03-27 at 9 01 53 PM
#92 and #88 issues are squashed with the aria2c tool.

@philipmat

Copy link
Copy Markdown
Owner

That looks pretty awesome (also yay VSCode!)

Can we make it so that if the computer doesn't have aria2c installed, we fall back on wget?

@albertfougy

Copy link
Copy Markdown
Contributor Author

wgetandAria2c-conditional
w/ conditional provided client does not have aria2c installed.

Screen Shot 2019-03-29 at 5 08 43 PM
w/ wget exclusive of aria2c

Besides adding the "fallback" conditional for wget.

  1. refactored deprecated string interpolation
  2. added shebang
  3. split long statements in a couple of places
  4. added another flag for wget to show progress from left to right

@philipmat
philipmat merged commit 434bed9 into philipmat:master Mar 30, 2019
@philipmat

Copy link
Copy Markdown
Owner

Thank you very much for making the code more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants