Repository navigation
fix(native): keep Xcode 26 toolbar compatibility narrowly scoped - #1
Merged
phiamo merged 1 commit intoOct 16, 2026
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow the Xcode 26 compatibility change in rdlabo-dev#268 to the older-SDK path. Compared with the original upstream implementation, this is one Swift file with 20 added lines; no tests or CI configuration are added.
Restore the existing Xcode 27 toolbar code, including per-item shared backgrounds, group spacers, and the iOS 27.1 axis preferences. For SwiftUI versions before 8, attach the existing
ShellVerticalBarsButtonitems through individual toolbar modifiers instead of usingForEachasToolbarContent. Attach groups and items in reverse because outer toolbar modifiers appear first. This preserves their source order and reuses the existing observed model and clear-background handling.Validation: Xcode 27.0 package build passed. The isolated fallback drawing code was compiled and displayed on an iOS 26.1 simulator with clear, default, outline, and solid buttons across two groups; clear remains background-free, solid remains tinted, and source order and group separation are retained. The Xcode 27.1 path is restored unchanged and was also built during verification. Xcode 26.3 itself is not installed locally, so a build with that exact toolchain still needs confirmation.