fix(parser): "for each <TYPE> card <verb> this way" counts only that card type

[minion1227]

Closes #4697.

Bug: Dread Summons — "Each player mills X cards. For each creature card put into a graveyard this way, you create a … Zombie" — created a Zombie for every milled card, not just creature cards. parse_for_each_clause recognized the tracked-set "this way" count but dropped the "creature" card-type filter, yielding the unfiltered QuantityRef::TrackedSetSize.

Fix: add parse_filtered_tracked_set_this_way, tried right before the bare TrackedSetSize fallback (mirroring the existing parse_filtered_revealed_this_way / parse_filtered_destroyed_this_way helpers): a "<TYPE> card <verb> this way" clause with a specific card type routes to the already-runtime-supported QuantityRef::FilteredTrackedSetSize { filter, caused_by: None }, which counts only the matching members of the most recent tracked set. A bare "card" (or typeless clause) returns None and keeps TrackedSetSize. Covers the whole "for each ⟨filter⟩ card ⟨verb⟩ this way" class (creature / land / artifact / … put into a graveyard / milled / exiled). No new engine variant.

CR 608.2c + CR 400.7.

Tests: "creature card put into a graveyard this way" → FilteredTrackedSetSize(Creature); bare "card …" → TrackedSetSize (regression). cargo fmt + clippy + parser combinator gate clean; 204 oracle_quantity + 2308 oracle_effect + 116 token-effect tests green (nonland-discarded / milled / destroyed cause-filtered paths intact).

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request implements parsing for the ' card this way' clause (e.g., 'creature card put into a graveyard this way') to support CR 608.2c and CR 400.7. It introduces the parse_filtered_tracked_set_this_way helper function using nom combinators, integrates it into the 'for each' clause parser, and adds corresponding unit tests. No review comments were provided, and the implementation adheres to the repository's architectural guidelines, so there is no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[github-actions]

Parse changes introduced by this PR · 22 card(s), 17 signature(s) (baseline: main e0eff39264c8)

3 card(s) · ability/Pump · field p/t: +cards moved/+cards moved → +filtered tracked set (creature)/+filtered tracked set (creature)

Examples: Ledev Champion, Orphans of the Wheat, Siege Striker

2 card(s) · ability/Draw · field count: cards moved → filtered tracked set (land)

Examples: Eumidian Wastewaker, Patient Rebuilding

2 card(s) · ability/GainLife · field amount: 4*cards moved → 4*filtered tracked set (creature)

Examples: Harmony of Nature, Marshaling the Troops

2 card(s) · ability/LoseLife · field amount: 2*cards moved → 2*filtered tracked set (creature)

Examples: Liliana's Indignation, Reign of Terror

1 card(s) · ability/ChangeZone · field target: mv cards moved- opponent controls permanent non-land → mv filtered tracked set (creature)- opponent controls permanent non-land

Examples: Teferi Akosa of Zhalfir

1 card(s) · ability/DealDamage · field amount: cards moved → filtered tracked set (Island)

Examples: Monsoon

1 card(s) · ability/Discard · field count: cards moved → filtered tracked set (Swamp)

Examples: Sink into Takenuma

1 card(s) · ability/Draw · field count: cards moved → filtered tracked set (Gate)

Examples: Guild Summit

1 card(s) · ability/Draw · field count: cards moved → filtered tracked set (Human)

Examples: Minas Tirith Garrison

1 card(s) · ability/Draw · field count: cards moved → filtered tracked set (creature)

Examples: Coerced Confession

1 card(s) · ability/GainLife · field amount: 2*cards moved → 2*filtered tracked set (creature)

Examples: Jaddi Lifestrider

1 card(s) · ability/Pump · field p/t: +cards moved/+cards moved → +filtered tracked set (Plains)/+filtered tracked set (Plains)

Examples: Plow Through Reito

1 card(s) · ability/PumpAll · field p/t: +cards moved/+cards moved → +filtered tracked set (Plains)/+filtered tracked set (Plains)

Examples: Charge Across the Araba

1 card(s) · ability/PutCounter · field counter: TrackedSetSize P1P1 → FilteredTrackedSetSize { filter: Typed(TypedFilter { type_filters: [Creature], controller: None, properties: [] }), cau…

Examples: Kaima, the Fractured Calm

1 card(s) · ability/PutCounter · field counter: TrackedSetSize time → FilteredTrackedSetSize { filter: Typed(TypedFilter { type_filters: [Creature], controller: None, properties: [] }), cau…

Examples: Out of Time

1 card(s) · ability/Token · field token: cards moved× +1/+1 White/Blue Merfolk (Creature Merfolk) → filtered tracked set (permanent)× +1/+1 White/Blue Merfolk (Creature Merfolk)

Examples: Wanderwine Farewell

1 card(s) · ability/Token · field token: cards moved× +4/+4 White Angel (Creature Angel) with Flying → filtered tracked set (creature)× +4/+4 White Angel (Creature Angel) with Flying

Examples: Devout Invocation

[matthewevans]

Maintainer review: passes the authorized review bar at head 383d737892e51265794e444156dfb2a1a2ddda88.