fix(client): make scry and surveil top-card reordering reliable#4589
Open
carlos4s wants to merge 1 commit into
Open
fix(client): make scry and surveil top-card reordering reliable#4589carlos4s wants to merge 1 commit into
carlos4s wants to merge 1 commit into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Author
|
@matthewevans would you pls review this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #684
The modal now keeps drag reorder support, separates the scroll container from the drag group, and adds explicit arrow reorder controls so players can change kept-on-top order before confirming.
Implementation method (required)
How was the engine/parser logic in this PR produced? Check exactly one:
/engine-implementerpipeline (plan → review-plan → implement → review-impl → commit)/engine-implementer— explain why belowIf you did not use
/engine-implementer, state why:CR references
None. Existing engine scry ordering behavior already follows CR 701.22a; this PR only fixes the frontend interaction used to submit that order.
Verification
./node_modules/.bin/vitest run src/components/modal/cardChoice/__tests__/libraryModals.test.tsxpassednode ../scripts/check-protocol-version.mjs && ./node_modules/.bin/tsc -b --noEmitpassed./node_modules/.bin/eslint .passed with existing warnings only, no errors