1095 intermediate nesting add tests + revert to roxygen 8.0.0 + fix - #1109
Conversation
|
I have read the CLA Document and I hereby sign the CLA |
|
@munoztd0 could you remove the workflow for cla? we are removing it across repos that are in pharmaverse now |
For sure, but will do it form main as this is not to be merge in main yet (then will rebase on it) 
|
| 'tt_from_df.R' | ||
| 'validate_table_struct.R' | ||
| 'zzz_constants.R' | ||
| RoxygenNote: 7.3.3 |
There was a problem hiding this comment.
can we set this to? roxygen 8.0.0
There was a problem hiding this comment.
it is already set to 8.0.0
Gabe just added 7.3.3. inadvertendly
There was a problem hiding this comment.
we need to work on this together @gmbecker , would you mind update your roxygen version,
There was a problem hiding this comment.
That must have been old, my local version right now is 8.0.0, so no problem there
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
|
hi @munoztd0 , can you close this PR, and raise one from the repo, you should have access now, added you in the team also, can you test in scda.test first |
| at_sibling = NULL, | ||
| cumulative = FALSE, | ||
| label_pos = if (!is.null(at_sibling)) "default" else "visible", | ||
| label_pos = if (!is.null(at_sibling)) "visible" else "default", |
| expect_equal(nrow(dontnest), 5) | ||
| }) | ||
|
|
||
| test_that("at_sibling creates intermediate row nesting", { |
There was a problem hiding this comment.
I had some local here too but we'll merge the two sets. thanks
| check_ok_label(split_label) | ||
| ## no topleft allowed | ||
| label_pos <- match.arg(label_pos, label_pos_values[-3]) | ||
| label_pos <- match.arg(label_pos, label_pos_values[-4]) |
gmbecker
left a comment
gmbecker
left a comment
There was a problem hiding this comment.
looks good we'll do any req'd cleanup and scda.testing on the main feature branch before merging to main
2738e96
into
pharmaverse:1095_intermediate_nesting
4 participants
at_siblingat_siblingbranches.