Skip to content

[NFR]: ADR route source #45

Closed
Closed

Description

@niden

Summary

ADR does not fire router:matchedRoute, so the Route panel stays empty. Feed RouteCollector from adr:beforeExecuteAction.

Current state

  • EventfulHandler fires adr:beforeExecuteAction with the Action as the source and the request as the data.
  • The request holds the route attributes (getAttributes()).

Proposed direction

Known limit

EventfulHandler is the terminal handler of the pipeline. A middleware that returns early skips this event, so the panel is empty for that request. A URL with no match also leaves the panel empty. Accept this for the first version.

Acceptance

  • In an ADR app, the Route panel shows the Action class and the attributes.
  • The MVC route source is unchanged.
  • Tests pass with full coverage. phpcs and phpstan pass.

Depends on

Part of

#13

Activity

  1. self-assigned this
    on Nov 3, 2026
  2. added theissue type on Nov 3, 2026
  3. moved this from Backlog to Active Sprint in Phalcon v5on Nov 3, 2026
  4. niden commented on Nov 4, 2026

    @niden
    SponsorMemberAuthor

    Resolved in #54

  5. moved this from Active Sprint to Implemented in Phalcon v5on Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

  • Status
    Implemented

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions