Skip to content

ci: also run Bencher perf tests on fork PRs - #1619

Merged
jkaczman merged 5 commits into
jk-bencher-v1from
jk-bencher-2-step-forks
Sep 28, 2026
Merged

jkaczman merged 5 commits into
jk-bencher-v1from
jk-bencher-2-step-forks

Conversation

@jkaczman

Copy link
Copy Markdown
Contributor

In addition to #1617, also run perf regression tests on fork PRs.

This uses Bencher's recommended 2-step PR workflow (with some minor tweaks) to safely make sure that forks can't abuse GITHUB_TOKEN / BENCHER_API_KEY / etc.

Steps:

  • Workflow 1: runs on the PR branch, builds the Docker image with the new pgdog binary, uploads image as an artifact (+ what PR it's from)
  • Workflow 2: runs off main branch after Workflow 1 concludes, uses secrets to upload the image, and run the Bencher CLI.

@jkaczman
jkaczman added this pull request to stack #1620 September 23, 2026 12:30
@jkaczman
jkaczman force-pushed the jk-bencher-2-step-forks branch from 128829a to 5ed1e0a Compare September 23, 2026 22:46
@jkaczman jkaczman closed this Sep 23, 2026
@jkaczman jkaczman reopened this Sep 28, 2026
@jkaczman
jkaczman force-pushed the jk-bencher-2-step-forks branch from 4506685 to 18240e6 Compare September 28, 2026 13:38
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jkaczman
jkaczman force-pushed the jk-bencher-2-step-forks branch from 18240e6 to 029d48d Compare September 28, 2026 17:32
@jkaczman
jkaczman force-pushed the jk-bencher-2-step-forks branch from 9acb829 to 1866550 Compare September 28, 2026 21:44
@jkaczman
jkaczman added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit 5d516b5 Sep 28, 2026
55 of 56 checks passed
@jkaczman
jkaczman deleted the jk-bencher-2-step-forks branch September 28, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant