Repository navigation
Conversation
Contributor
Author
|
Doesn't seem possible with Blacksmith.
Oh well! Worth a try. |
Collaborator
|
Yup! |
pull Bot
pushed a commit
to TheTechOddBug/pgdog
that referenced
this pull request
Sep 29, 2026
…sions (pgdogdev#1617) Automatically detect performance regressions in CI using [Bencher](https://bencher.dev/) Runs our pre-existing load-balancer, sharding and pooler tests (loc. in benches/perf) in a workflow; measures mean TPS over 3 minutes, and looks at the history (from main) to see if the mean TPS dropped by more than 3%. If it does, it comments on the PR with the numbers, and emits an error in CI. I tested Bencher many times, and the results were always <1% variance! Contrary to this, [Blacksmith, GH Actions had variance of over 9%](pgdogdev#1613), and did not seem suitable for what we want. It's also free for open source :) Implementation wise: this re-uses our pgdog-base-runtime image, re-builds with a built (via Blacksmith) pgdog binary off the tested PR's branch, copies over perf scripts, asks Bencher to run it, and Bencher handles everything from there. Many future plans to add more tests on top of this Something notable to mention: - This will not work when a fork is being merged in because of GitHub secrets. This is fixable, it will just require implementing Bencher's two-step workflow for that case. I'm going to follow up with another PR fixing that. re pgdogdev#1585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before I try out Bencher, which is more complex to setup, curious to see how our current Blacksmith runners do in terms of variance. Not planning on merging this unless it works well.
Using 32vcpu runners (max) to try to get (at least mostly) dedicated machines, since each core is dedicated.
This just has a basic workflow right now to emit TPS from our current benches/perf/{lb,pooler,sharding} benches.