use current page and teaser for the description - #47
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are fully reviewed, tested, and have no unresolved blocking issues.
Pull request overview
Updates Open Graph descriptions to use the current multipage section and teaser content.
Changes:
- Selects the current page with
generate_postdata(). - Stops descriptions at
<!--more-->. - Adds regression tests for both behaviors.
File summaries
| File | Summary |
|---|---|
tests/phpunit/tests/class-test-opengraph.php |
Adds multipage and teaser coverage. |
opengraph.php |
Implements page-specific teaser extraction. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
The description was always built from the whole
post_content, so every page of a multipage post got the same one. It now uses core'sgenerate_postdata()to pick the page from thepagequery var (works for the classic<!--nextpage-->and the block form).While at it, the description is cut at the
<!--more-->tag, the same way we do it in the ActivityPub plugin. That is a small behavior change for posts with a more tag, they get the teaser instead of the first 55 words.og:urlstill points to the first page, I left that alone for now.