feat: implement issue #528 — SonarCloud: test assertion quality (S5906) - #548
feat: implement issue #528 — SonarCloud: test assertion quality (S5906)#548don-petry wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reached
Next review available in: 20 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Jest test assertions across multiple test files to use more idiomatic matchers, replacing '.length' checks with 'toHaveLength()' and '.toBe(null)' with 'toBeNull()'. There are no review comments to address, and I have no additional feedback to provide.
|
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| const duration = Date.now() - startTime | ||
|
|
||
| expect(processed.length).toBe(BATCH_SIZE) | ||
| expect(processed).toHaveLength(BATCH_SIZE) |
There was a problem hiding this comment.
Suggestion: The benchmark only verifies the number of returned entries, so an implementation that duplicates one result, associates results with the wrong threads, or returns 100 unclassified entries would still pass. Assert that each result corresponds to the input thread and has the expected classified status and label so the throughput test also validates the batch-processing contract. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Batch benchmark can pass incorrect per-thread results.
- ⚠️ Thread-to-result association regressions may go undetected.
- ⚠️ Classification status and label regressions lack coverage.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/gmail-ai-classifier/tests/performance-scalability.test.js
**Line:** 124:124
**Comment:**
*Incomplete Implementation: The benchmark only verifies the number of returned entries, so an implementation that duplicates one result, associates results with the wrong threads, or returns 100 `unclassified` entries would still pass. Assert that each result corresponds to the input thread and has the expected classified status and label so the throughput test also validates the batch-processing contract.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-08-18T21:46:47Z. |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 425683015c84f8b433ddeba32e61c2613f8913cf
Review mode: triage-approved (single reviewer)
Summary
Test-only PR (2 files, +4/-4) that rewrites four Jest assertions to idiomatic matchers: three in src/calendar-to-sheets/tests/index.test.js (.length toBe(1) → toHaveLength(1); toBe(null) → toBeNull() ×2) and one in src/gmail-ai-classifier/tests/performance-scalability.test.js (.length toBe(BATCH_SIZE) → toHaveLength(BATCH_SIZE)). All replacements are semantically equivalent to the originals — no behavior change. Confirms the triage assessment: low-risk, mechanical, exactly scoped to the linked issue.
Linked issue analysis
Closes #528 (SonarCloud S5906 — test assertion quality). The issue lists exactly 4 findings: 3 in calendar-to-sheets tests, 1 in gmail-ai-classifier performance test. This PR fixes precisely those 4 assertions with real fixes (no NOSONAR suppressions). SonarCloud quality gate on this PR passed with 0 new issues, satisfying the acceptance criteria (findings resolved, no behavior change, CI green).
Findings
- No security-relevant changes: no auth, secrets, dependencies, workflows, or executable logic touched.
- Secret scan (MCP): run_secret_scanning tool not available in this run — noted, not blocking; gitleaks CI check passed (SUCCESS).
- CodeAnt left one advisory inline suggestion about the benchmark only asserting result count — that weakness pre-exists this PR (the assertion was .length-based before and is semantically unchanged); out of scope here and non-blocking.
- Advisory bots Codex, Qodo, and CodeRabbit were rate/billing-limited; Gemini Code Assist and CodeAnt did review (no blocking feedback). This sweep re-review supersedes the earlier rate-limited hold.
- No unanswered human-reviewer questions; no human change requests.
CI status
All substantive checks green: build-and-test, Node.js Tests, coverage, Playwright UI Tests, CodeQL (actions/js-ts/python), SonarCloud (quality gate passed, 0 new issues), gitleaks secret scan, dependency audit, AgentShield — all SUCCESS. A few Dev-Lead Agent dispatch/ci-relay runs show CANCELLED, but these are superseded agent-orchestration runs (the final dev-lead dispatch at 20:46:14Z succeeded), not code checks.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
2 participants
User description
Closes #528
Implemented by dev-lead agent. Please review.
CodeAnt-AI Description
Improve test assertion quality for SonarCloud compliance
What Changed
Impact
✅ SonarCloud test-quality checks pass✅ Clearer test failure messages✅ Existing benchmark and configuration coverage preserved💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.