Repository navigation
Conversation
Bandit walks an absolute scan target. When the scan root is relative, exclude entries stayed relative (temp/*) and never matched /repo/temp/..., so configured excludes were scanned and reported as production security issues.
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
collect_exclude_dirsdocuments that it returns absolute directories for external tools. Whenscan_rootis relative (the common path of a relative file list), it returned paths liketemp. Bandit then turns an existing directory into the globtemp/*and compares it to absolute filenames such as/repo/temp/file.py. That glob does not match, sodesloppify exclude tempstill let Bandit scan the directory and import those findings as production security issues.Observed on desloppify 1.0: a project with
exclude: ["temp"]still recorded 5517 Bandit findings undertemp/as zoneproduction. File discovery itself honored the exclude (59 project files). Only the Bandit subprocess scanned the vendor tree.Fix
Resolve
scan_rootand emit absolute directories. Already-absolute patterns are preserved. A unit test covers a relative scan root plus a runtimetempexclusion.Verification
pytest desloppify/tests/detectors/test_external_adapters.py::TestCollectExcludeDirs— 7 passed.