Skip to content

fix(cxx): avoid false API matches and preserve security fallback - #899

Open
Sk1tch wants to merge 3 commits into
peteromallet:mainfrom
Sk1tch:codex/cxx-security-api-boundaries
Open

Sk1tch wants to merge 3 commits into
peteromallet:mainfrom
Sk1tch:codex/cxx-security-api-boundaries

Conversation

@Sk1tch

@Sk1tch Sk1tch commented Oct 27, 2026 •

Copy link
Copy Markdown

Cppcheck reports missing headers and unsupported macros even when it exits zero. The C++ security pipeline treated those results as complete AST coverage. Its normalizer also matched the gets substring inside the missing include Widgets/Input/SVirtualJoystick.h as an unsafe C call.

Require identifier boundaries around unsafe API names. Treat cppcheck configuration failures as incomplete security analysis, activating the existing per-file retries and regex fallback. This complements #864, which handles the code-diagnostic phase; phase-level changes are left in that existing PR.

Validation: all C++ plugin tests pass, including regressions for unsafe API boundaries and retained regex security detection after a zero-exit configuration failure. The originating controller reports incomplete analysis instead of a fabricated unsafe-string finding. The core suite has 5,808 passes, 5 skips, and two instances of an existing review-prompt failure, also reproduced on the unchanged upstream module.

@Sk1tch Sk1tch changed the title fix(cxx): require identifier boundaries for unsafe API names fix(cxx): treat cppcheck configuration errors as reduced coverage Oct 27, 2026
@Sk1tch Sk1tch changed the title fix(cxx): treat cppcheck configuration errors as reduced coverage fix(cxx): avoid false API matches and preserve security fallback Oct 27, 2026
github-actions Bot added a commit to citizenadam/desloppify that referenced this pull request Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant