Conversation
Boulea7
marked this pull request as ready for review
October 1, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat a standalone
-as the first positional argument, preserving it and the remaining arguments instead of continuing flag parsing. This also prevents a later argument from being selected as a subcommand. Regression tests cover both flag set constructors and keep-working as a flag value.Local
go test -count=1 -race ./...passes. With gofumpt v0.12.0, the full-tree check fails on the same existing formatting difference inffval/collections.goon unmodified main; the changed files pass. Revive v1.17.0 reports the same three existing warnings on both revisions.GitHub Actions has not executed the code checks (
action_required, zero jobs).