Skip to content

[BREAKINGCHANGE] remove dashbaord resource dependecy#97

Merged
shahrokni merged 1 commit intomainfrom
refactor/remove_dashbaord_Resource_core
Apr 14, 2026
Merged

[BREAKINGCHANGE] remove dashbaord resource dependecy#97
shahrokni merged 1 commit intomainfrom
refactor/remove_dashbaord_Resource_core

Conversation

@shahrokni
Copy link
Copy Markdown
Contributor

@shahrokni shahrokni commented Apr 2, 2026

Description

There is an ongoing effort to remove the core the dependency and replace them with what we have in the Spec.
This PR removes some of the dependencies (mostly DashboardResource, EphemeralDashboardResource) which have been already mentioned by @Nexucis

How does it replace the dependencies?

The PR introduces a new interface which represents an internal definition of any-Dashboard-Resource named DashboardMinimalResource.

  • DashboardResource, EphemeralDashboardResource from EditDatasourcesButton.tsx
  • DashboardResource, EphemeralDashboardResource from serializeDashboard.ts
  • DashboardResource, EphemeralDashboardResource from LeaveDialog.tsx
  • DashboardResource, EphemeralDashboardResource from common.ts
  • DashboardResource, EphemeralDashboardResource from dashboard-provider-api.ts
  • DashboardResource, EphemeralDashboardResource from DatasourceStoreProvider.tsx
  • DashboardResource, EphemeralDashboardResource from useDashboard.tsx
  • DashboardResource from dashboard-provider.tsx
  • DashboardResource, EphemeralDashboardResource from DashboardApp.tsx
  • Some important changes in dashboards/src/context/DashboardProvider/DashboardProvider.tsx

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@shahrokni shahrokni force-pushed the refactor/remove_dashbaord_Resource_core branch 4 times, most recently from facc8a6 to 872354c Compare April 13, 2026 10:16
@shahrokni shahrokni requested a review from jgbernalp April 13, 2026 10:47
@shahrokni shahrokni marked this pull request as ready for review April 13, 2026 10:47
@shahrokni shahrokni requested a review from a team as a code owner April 13, 2026 10:47
@jgbernalp jgbernalp changed the title [BREAKINGCHANE] remove dashbaord resource dependecy [BREAKINGCHANGE] remove dashbaord resource dependecy Apr 13, 2026
@shahrokni shahrokni force-pushed the refactor/remove_dashbaord_Resource_core branch 5 times, most recently from 2f6e05e to 5b15e50 Compare April 13, 2026 13:22
@shahrokni shahrokni requested a review from jgbernalp April 13, 2026 13:26
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the refactor/remove_dashbaord_Resource_core branch from 5b15e50 to 3f7a56c Compare April 14, 2026 07:46
@shahrokni shahrokni requested a review from jgbernalp April 14, 2026 07:50
@shahrokni shahrokni merged commit 2dad8ca into main Apr 14, 2026
12 checks passed
@shahrokni shahrokni deleted the refactor/remove_dashbaord_Resource_core branch April 14, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants