Repository navigation
build: keep test certificate fixtures out of the images (backport #979 to 0.9.x) - #980
Merged
Merged
Conversation
The trust-store test's fixture holds the compromised eMudhra certificates (CVE-2026-111943). COPY ./packages put it in every client and server image, where a search of the image's files for those certificates reports it, although nothing trusts it. CI and the release build from a Git context, where BuildKit ignores .dockerignore, so docker/Dockerfile now uses COPY --exclude=**/tests/*.pem (dockerfile frontend 1.19, pinned by digest), .dockerignore keeps the same rule for local builds, and both E2E jobs fail if any .pem is under /opal/packages in the images. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 27e4852)
EliMoshkovich
requested review from
zeevmoney
and
a balanced review from Copilot
October 23, 2026 16:18
zeevmoney
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Backport of #979 to
release/0.9.x, so 0.9.10 doesn't ship the trust-store test's certificate fixture.#978 added
packages/**/tests/*.pemto.dockerignore, but CI and the release build from a Git context, where BuildKit doesn't apply.dockerignore. So 0.9.10-rc.2 still carriesopal_common/tests/emudhra_compromised_cas.pemin every client and server image. Nothing trusts it, but a search of the image's files for the compromised eMudhra certificates (CVE-2026-111943) reports it.Changes proposed
git cherry-pick -xof #979 (27e4852). The only conflict was the comment above #978's.dockerignorerule, which now takes #979's wording.docker/Dockerfile:COPY --exclude=**/tests/*.pem ./packages ./packages/in thecommonandcommon-alpinestages, with# syntax=docker/dockerfile:1.19pinned by digest as the first line..dockerignore: the same rule for local builds, with the corrected comment.tests.yml: both E2E jobs fail if any*.pemis under/opal/packagesin the client or server image.Verification
The same change on master (#979) passed CI there. It was also checked with Git-context builds, as CI does: no
.pemin any of the four images, with the published0.9.10-rc.2images as the control that still has the fixture. This PR's CI runs the same image check on this branch.Check List (Check all the applicable boxes)
🤖 Generated with Claude Code