Refactor pgsmQueryStats structure - #841
Open
artemgavrilov wants to merge 2 commits into
Open
artemgavrilov wants to merge 2 commits into
artemgavrilov wants to merge 2 commits into
Conversation
Intstead of storing whole Counters structure in in pgsmQueryStats keep only what's needed. That reduces size of entries that we store in the list. Also local statisctics can be stored differently rather that final entry.
Remove ErrorInfo from pgsmQueryStats and pass it directly to pgsm_store. That will reduce memory pgsmQueryStats need and also simplifies logic.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
==========================================
+ Coverage 88.50% 88.54% +0.04%
==========================================
Files 3 3
Lines 1340 1336 -4
Branches 196 196
==========================================
- Hits 1186 1183 -3
Misses 75 75
+ Partials 79 78 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
artemgavrilov
marked this pull request as ready for review
September 7, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep in pgsmQueryStats structure only what's needed. That reduces struct size and decouples it from Counters structure as they have different needs. Next step will be rework how we count things there.