Skip to content

Address review feedback on no-permit fallback implementation#1135

Merged
ebma merged 2 commits intostagingfrom
copilot/sub-pr-1133-again
May 4, 2026
Merged

Address review feedback on no-permit fallback implementation#1135
ebma merged 2 commits intostagingfrom
copilot/sub-pr-1133-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

Addresses three review comments on the EVM→Alfredpay no-permit fallback path.

  • Narrow nonces() error handling – Catch only ContractFunctionExecutionError (contract revert) when probing EIP-2612 support. Network/transport errors now propagate for retry instead of silently falling back to the no-permit flow.

  • Validate user-submitted tx hasheswaitForUserHash now verifies receipt.from matches state.walletAddress, preventing unrelated successful tx hashes from advancing the ramp.

  • Dedicated no-permit phase messages – Added squidRouterNoPermitApprove, squidRouterNoPermitSwap, squidRouterNoPermitTransfer i18n keys with accurate UX copy (approve/swap/transfer) instead of reusing the permit authorization message.

// Before: any error silently falls back
} catch {
  userNonce = null;
}

// After: only contract-level reverts indicate missing permit support
} catch (error) {
  if (error instanceof ContractFunctionExecutionError) {
    userNonce = null;
  } else {
    throw error;
  }
}

@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for vortexfi ready!

Name Link
🔨 Latest commit b53e604
🔍 Latest deploy log https://app.netlify.com/projects/vortexfi/deploys/69f8da06fa4d2f0008ad8036
😎 Deploy Preview https://deploy-preview-1135--vortexfi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for vortex-sandbox ready!

Name Link
🔨 Latest commit b53e604
🔍 Latest deploy log https://app.netlify.com/projects/vortex-sandbox/deploys/69f8da06fc397a0008ee4cfd
😎 Deploy Preview https://deploy-preview-1135--vortex-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI changed the title [WIP] Create new production release Address review feedback on no-permit fallback implementation May 4, 2026
Copilot AI requested a review from ebma May 4, 2026 17:43
Copilot finished work on behalf of ebma May 4, 2026 17:43
@ebma ebma marked this pull request as ready for review May 4, 2026 17:46
@ebma ebma merged commit c629ddd into staging May 4, 2026
6 checks passed
@ebma ebma deleted the copilot/sub-pr-1133-again branch May 4, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants