Address review feedback on no-permit fallback implementation#1135
Merged
Address review feedback on no-permit fallback implementation#1135
Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…r, fix phase messages
Copilot
AI
changed the title
[WIP] Create new production release
Address review feedback on no-permit fallback implementation
May 4, 2026
ebma
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three review comments on the EVM→Alfredpay no-permit fallback path.
Narrow
nonces()error handling – Catch onlyContractFunctionExecutionError(contract revert) when probing EIP-2612 support. Network/transport errors now propagate for retry instead of silently falling back to the no-permit flow.Validate user-submitted tx hashes –
waitForUserHashnow verifiesreceipt.frommatchesstate.walletAddress, preventing unrelated successful tx hashes from advancing the ramp.Dedicated no-permit phase messages – Added
squidRouterNoPermitApprove,squidRouterNoPermitSwap,squidRouterNoPermitTransferi18n keys with accurate UX copy (approve/swap/transfer) instead of reusing the permit authorization message.