Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
gianfra-t
commented
Apr 13, 2026
| throw new Error("NablaSwapPhaseHandler: Invalid EVM transaction data. This is a bug."); | ||
| } | ||
|
|
||
| const txHash = await baseClient.sendRawTransaction({ |
Contributor
Author
There was a problem hiding this comment.
Caveat: not currently doing a swap simulation first.
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…routing, network params - distribute-fees-handler: submit presigned raw EVM transaction instead of signing with funding account - distribute-fees-handler: fix presigned tx lookup to use "distributeFeesEvm" for EVM flows - distribute-fees-handler: pass explicit network to checkEvmTransactionStatus - nabla.ts: import NABLA_ROUTER_BASE and NABLA_QUOTER_BASE from shared constants - route-resolver: restore AssetHub→PIX routing using OfframpToPixStrategy Agent-Logs-Url: https://github.com/pendulum-chain/vortex/sessions/9b62fc69-63f0-4f94-8dd5-eb0138bebf28
Contributor
Addressed all remaining unresolved comments in commit d5594ce:
The fee splitting concern (all fees going to vortex payout address) is left as-is since it's a design decision that would require additional partner payout infrastructure on EVM. |
…p responses to ensure that SDK users can't accidentally submit transactions too early
…le swap deadlines
…r accurate swap calculations
…ate related logic in fee distribution functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1112
Description
Adds new transactions creators, phases and quote logic to handle BRLA onramps / offramps on Base.
New flow can be seen at the journey and fees diagram.
Review focus
Changes are focused on:
The quote engine logic files, starting with the two new strategies for onramp and offramp.
Transaction creation routes: onramp and offramp.
Phases logic modifications, and additions.