Repository navigation
feat(forgekeeper)!: use opencode-forgekeeper as the server and RPC ID - #90
Merged
Merged
Conversation
The server kept opencode-forge-session-title's plugin and RPC ID, so OpenCode's plugin list showed the deprecated package's name for opencode-forgekeeper. Use opencode-forgekeeper for both. OpenCode scopes plugin storage by plugin ID, so the code that read the old package's single `target` records and removed its whole-log keys has nothing left to read, and goes too. BREAKING CHANGE: Nothing stored under opencode-forge-session-title carries over. Sessions return to branch-based naming until their targets are set again, each PR/MR records a new review baseline, and RPC callers need the opencode-forgekeeper ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
The server kept the deprecated
opencode-forge-session-titleplugin and RPC ID, so OpenCode's plugin list showed the old package's name foropencode-forgekeeper. This usesopencode-forgekeeperfor both, and removes the code that read the old package's storage formats, which a new ID can't see.BREAKING CHANGEfooter if you squash, so release-please releases 2.0.0.How to set up and validate locally
mise run build forgekeeper, then point anopencode.jsonplugin entry atpackages/forgekeeper/dist.opencode-forgekeeper, andopencode api post '/api/rpc/opencode-forgekeeper/target?location[directory]=<dir>' --data '{"input":{"sessionID":"<id>"}}'answers.Tested at 5348900 with OpenCode 2.0.26: the plugin list showed the new ID, the RPC answered under it, and the old ID's RPC was unavailable.