Repository navigation
fix(homeassistant): document one notification per pending request - #63
Merged
Merged
Conversation
Release automation only tracks the plugin packages, so the concurrent wait fix in packages/_shared would never have been published on its own. This carries it into a release by documenting the behaviour it changes. Records that each pending request now gets its own webhook and poll, that requests can be answered in any order, that the session resumes only once all of them are answered, and that automations must key responses by request ID rather than assuming a single outstanding request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this exists
#62 fixed concurrent waits but touched only
packages/_shared/src/agent-state.ts. Release-please tracks the five plugin packages and not_shared, so it found nothing releasable:_sharedis bundled into each plugin at build time, so the fix is real but invisible to release automation. The earlier_sharedchange in 0.7.0 only shipped because that commit also touchedpackages/homeassistant/.This documents the behaviour change in the plugin README, which both informs users and puts the work on a releasable path so 0.7.6 can be cut.
Content
Records that each pending request gets its own webhook and poll, that requests can be answered in any order, that the session resumes only once all are answered, and that automations must key responses by request ID rather than assuming a single outstanding request. That last point matters: an automation that overwrote a single helper value would now be racing two live requests.
Follow-up worth considering
Any future
_shared-only fix will hit the same wall. Options: addpackages/_sharedtorelease-please-config.jsonas a non-published component to force dependent bumps, or keep the current convention of pairing_sharedchanges with a plugin-visible change. Not changed here to keep this release narrow.mise run lintandbuildpass.