Compability with simple-navigation 4.0.0

[pzgz]

This fixed worked for me in a while, with simple-navigation 4, also listed in #13

[pzgz]

@zealot128 Sure thing, just did. Thanks^_^

[webchi]

Work for me with simple-navigation 4.0.3

[gltarsa]

While this fix enabled the use of link_html wonderfully, it causes options, like icon: [fa fa-ticket] to stop working. In our app, that means code like this:

    primary.item :ticket,
      "Ticket",
      url_for('//mycompany/ticket'),
      link_html: { target: '_blank' },
      icon: ['fa fa-ticket'],
      if: -> { can? :create, Ticket }

No longer works as it did. That snippet used to render as a small ticket icon followed by the word "Ticket" now renders as just the word. No CSS for the icon is present in the view. I am investigating the problem, but cannot promise I will be able to deliver a fix.

[pdf]

This project is looking for a maintainer, the reason I haven't merged this is that I have not had time to test it against all supported features.

[gltarsa]

I understand. My ruby skills are not yet up to taking this on, though I spent some time trying to debug it. I was hoping the author of the PR might be able to look into it. FWIW, I found another gem that does something similar simple_navigation_bootstrap and let that author know about your desire to pass the torch. Unfortunately for me, that gem has the same problem. I think something changed in the 4.0.0 release with regard to renderers and the wiki has not been updated.

[gltarsa]

I found the problem with the icon code. Apparently the icon options have moved and are no longer in li_options.

Replacing line 10 in lib/simple_navigation/rendering/renderer/bootstrap.rb (icon = li_options.delete(:icon)) with icon = item.send("options")[:icon] fixes the problem.

options is not exposed in the Item class, so the send is necessary to workaround that.

I was unable to get the tests running, or I would have added one for this. Unfortunately, I have spent much more time on this than I expected and have to get my code into production.

@pzgz, you may want to change your PR to include this.