Integration over a subdomain of a Tabulated1D#42
Open
HunterBelanger wants to merge 2 commits intopaulromano:mainfrom
Open
Integration over a subdomain of a Tabulated1D#42HunterBelanger wants to merge 2 commits intopaulromano:mainfrom
HunterBelanger wants to merge 2 commits intopaulromano:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add the functionality to perform a definite integral over a sub-range of a
Tabulated1Dfunction. As part of this work, I also added some static method to replace the old interpolation/integration logic, so that they could be more easily reused in different use cases.There was already a
Tabulated1D.integralmethod, but it returned a tabulation of the cumulative integral at all points, but this does not allow one to reconstruct the true curvature of the integral between tabulated points according to the interpolation rule. This new method facilitates this more easily.