You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bug - [Slider with Input] - [should accept , as comma for non en US locales] #12052
When using , if the adjacent input is initialized with a non-English decimal separator (comma, e.g. "50,2"), the component breaks: the slider/input get out of sync and/or parsing fails. This happens even when the page/parent container has a non-EN lang (e.g. lang="el").
changed the title [-]Bug - [Component] - [short description][/-][+]Bug - [Slider with Input] - [should accept , as comma for non en US locales][/+]on Oct 13, 2025
Is it expected that you would pass in a string like "50,2" to the inputValue prop
from there, PF would transform that string to a decimal number internal to the component
that transformed number would be what's displayed in the input as well as what's stored internally
Or rather, is the expectation that the input would still display the commas 50,2, and just internally the component would transform to a decimal to do any calculations, then render it back in the input with the comma again
The same confirmations above would likely apply to the slider steps as well, in terms of their value and displayed label.
Would you also be able to confirm whether this is something specific to Slider, or if there are other instances of numbers needed for input where this is a problem? Thinking namely of the NumberInput component
We had a go at this in #12599. As of right now, it adds a lot of complexity. It sounds like you are already normalizing the input yourself. We'd like to skip adding this for now, but we'd be happy to revisit this if it comes up for more teams again in the future (or if our JavaScript overlords come up with a built-in parser).
Activity
fix(storage): normalize locale decimals for PatternFly slider input
[-]Bug - [Component] - [short description][/-][+]Bug - [Slider with Input] - [should accept , as comma for non en US locales][/+]storage: normalize locale decimals for PatternFly slider input
storage: stop using inputValue from slider as it cannot parse localiz…
storage: normalize locale decimals for PatternFly slider input
storage: stop using inputValue from slider as it cannot parse localiz…
storage: stop using inputValue from slider as it cannot parse localiz…
thatblindgeye commentedon Oct 17, 2025
@KKoukiou Just to confirm some things:
"50,2"to theinputValueprop50,2, and just internally the component would transform to a decimal to do any calculations, then render it back in the input with the comma againThe same confirmations above would likely apply to the slider steps as well, in terms of their value and displayed label.
Would you also be able to confirm whether this is something specific to Slider, or if there are other instances of numbers needed for input where this is a problem? Thinking namely of the NumberInput component
github-actions commentedon Dec 18, 2025
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
4 remaining items
github-actions commentedon Jun 24, 2026
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
rebeccaalpert commentedon Jul 27, 2026
Looking at language detection, we could use the inherited lang attribute, but OpenShift doesn't change this when language changes.
OpenShift uses https://github.com/i18next/i18next-browser-languageDetector (this is just the translated codebase I'm most familiar with) and then stores language changes via a dropdown in local storage.
feat(Slider): Recognize localized number input
feat(Slider): Recognize localized number input
feat(Slider): Recognize localized number input
feat(Slider): Recognize localized number input
feat(Slider): Recognize localized number input
feat(Slider): Recognize localized number input
feat(Slider): Recognize localized number input
rebeccaalpert commentedon Aug 3, 2026
We had a go at this in #12599. As of right now, it adds a lot of complexity. It sounds like you are already normalizing the input yourself. We'd like to skip adding this for now, but we'd be happy to revisit this if it comes up for more teams again in the future (or if our JavaScript overlords come up with a built-in parser).