Skip to content

Tone the dark mode dividers back down - #148

Merged
aashu2006 merged 1 commit into
mainfrom
fix/subtler-dividers
Sep 29, 2026
Merged

aashu2006 merged 1 commit into
mainfrom
fix/subtler-dividers

Conversation

@aashu2006

@aashu2006 aashu2006 commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

#115 raised --border to 3:1 for #99, but every divider on the site uses
it, so the lines under the navbar and between sections turned bright
grey. WCAG 1.4.11 only asks for 3:1 on outlines you need to find a
control, and those use --input (inputs, selects, outline buttons), which
stays at about 3.1:1. --border goes to 22% lightness, about 1.6:1: still
visible, unlike the 1.3:1 before #115, but quiet.

The contrast test now checks --input, the token the rule applies to.

Summary by CodeRabbit

  • Visual Improvements
    • Dark-mode section divider borders are now darker, making them less prominent against the surrounding interface. Input control outlines remain unchanged, preserving their separate visual treatment. These updates apply to both standard content dividers and sidebar dividers.

#115 raised --border to 3:1 for #99, but every divider on the site uses
it, so the lines under the navbar and between sections turned bright
grey. WCAG 1.4.11 only asks for 3:1 on outlines you need to find a
control, and those use --input (inputs, selects, outline buttons), which
stays at about 3.1:1. --border goes to 22% lightness, about 1.6:1: still
visible, unlike the 1.3:1 before #115, but quiet.

The contrast test now checks --input, the token the rule applies to.
@strix-security

Copy link
Copy Markdown

Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here.

So far, Strix has reviewed 14 pull requests across this workspace.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0e12050b-6660-4c9e-b1b4-4d61355d413b

📥 Commits

Reviewing files that changed from the base of the PR and between 0a8a6dd and 93b093a.

📒 Files selected for processing (2)
  • src/accessibility.test.ts
  • src/index.css
 _______________________________________________
< Finding your faults 10 times faster than Mom. >
 -----------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@aashu2006
aashu2006 merged commit d499278 into main Sep 29, 2026
14 of 15 checks passed
@aashu2006
aashu2006 deleted the fix/subtler-dividers branch September 29, 2026 15:09

This branch was successfully deployed

1 active deployment
Preview — 93b093a3 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant