Repository navigation
feat(cli): add the polkadot mainnet network preset - #1456
Open
decrypto21 wants to merge 6 commits into
Open
decrypto21 wants to merge 6 commits into
decrypto21 wants to merge 6 commits into
Conversation
Contributor
|
CI Status: 24 required jobs green, 17 passed and 7 skipped by path filter. All job results
Signing credentials: failure as of 2026-10-15, a release may fail Commit |
Contributor
Bundle size reportCompared with
WebAssembly modules
No file changed size. Commit: 8db6a1a |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--network polkadotfor Polkadot mainnet: Polkadot People, Bulletin and Asset Hub, with dotNS under.dot. Refs #474.Endpoints.
wss://polkadot-people-rpc.polkadot.iowss://bulletin-rpc.polkadot.iowss://polkadot-asset-hub-rpc.polkadot.io@parity/dotns-cli1.0.0 uses the same endpoints (paritytech/dotns-sdk#335). The ignored live test checks that each endpoint reports the advertised genesis hash and a chain name that matches its role.dotNS. The Polkadot deployment manifest from paritytech/dotns#340 is vendored byte-for-byte as
deployments/polkadot-420420419.json. The preset readsDotnsPopControllerout of it at compile time, so the manifest is the only copy of the address. Its 20 addresses match thev1.0.0-pcf.1release table.On chain:
ProtocolRegistry.tld()returns.dot;NetworkSuffixisdoton Asset Hub and on People;Discovery reads
DotnsGateway.DispatcherAddressfirst. While Polkadot Asset Hub leaves it unset, the CLI's own Asset Hub reads use the manifest's controller instead. Referendum 1955 sets the dispatcher to that same controller.Real identities. A preset without
disposable_identities:--mnemonic/HOST_CLI_SIGNER_MNEMONIC, and never writes the plaintext account store;dev,--auto-accept,/approval automatic);--product-config, whose seeded grants are never prompted for and persist in the core database.paseo-next-v2andpreviewnetsetdisposable_identities, so they keep their stored accounts and automatic approval.every_disposable_preset_routes_to_a_test_networkholds every such preset to test-network hosts.Identity backend. The preset ships without one. On polkadot the backend is only used by the username-creation flows, which the preset refuses, so nothing in it needs one today. A command that does need one names
HOST_CLI_IDENTITY_BACKEND_BASE. The production URL is tracked on #474, pending confirmation from PCF.Not covered. The in-core username lookup has no controller fallback, so serving hosts resolve usernames on polkadot once referendum 1955 sets the dispatcher. No mainnet usernames can be registered before then.
E2E script.
cross-product-ringvrf-e2e.tsreads the People genesis fromchain.getChainInfo, so it runs on whichever preset the host serves.@parity/truapidoes not export a fixed People genesis to import.Testing.
cargo testfor truapi and truapi-host-cli; workspace clippy-D warningson the pinned nightly;make fmt-check.identity-check,alloc-checkandpgas-checkread mainnet correctly;signing-hostrefuses a missing mnemonic,--auto-acceptand--product-config, and with--mnemonicwrites no account store.