Repository navigation
refactor(truapi): sign personhood through PersonhoodSigner - #1435
Merged
Merged
Conversation
Contributor
Bundle size reportCompared with
WebAssembly modules
Changed files (3)
Commit: baf6ade |
Contributor
|
CI Status: 24 required jobs green, 21 passed and 3 skipped by path filter. All job results
Signing credentials: failure as of 2026-10-15, a release may fail Commit |
pgherveou
commented
Oct 15, 2026
pgherveou
marked this pull request as ready for review
October 15, 2026 10:41
pgherveou
enabled auto-merge
October 15, 2026 11:24
johnthecat
approved these changes
Oct 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 15, 2026
filvecchiato
approved these changes
Oct 15, 2026
valentinfernandez1
self-requested a review
October 15, 2026 17:31
valentinfernandez1
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PersonhoodSigner(member key, alias, ring proof) instead of letting every call site derive these from the raw personhood entropy. Until now each allocator received the raw entropy and derived them itself, so the secret travelled through the allocation code and every caller had to hand it over.Whoever holds the keys implements the signer, so a wallet can answer these calls without giving out its entropy.
For now callers build a
FixedPersonhoodSignerfrom the entropy they hold; later the wallet will own the signer and pass it in.