Repository navigation
Conversation
…tion pending_claim_labels filtered out claims with mintedAt + reservationDuration < now, mirroring the controller's old expiry. dotNS removed that expiry (expirePendingClaim is gone and _settlePending settles a claim of any age), so the filter made every unsettled lite username unresolvable 7 days after minting. Drop the filter and its reservationDuration and Timestamp.Now reads. Fixes paritytech/platform-bugs#39
Contributor
Bundle size reportCompared with
WebAssembly modules
Changed files (1)
Commit: 46bcf09 |
Contributor
|
CI Status: 24 required jobs green, 21 passed and 3 skipped by path filter. All job results
Signing credentials: failure as of 2026-10-14, a release may fail Commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/paritytech/platform-bugs/issues/39: lite usernames stop resolving 7 days after onboarding.
Why:
pending_claim_labelsdrops claims older thanreservationDuration, mirroring the controller's old expiry. dotNS has since removed that expiry: pending claims never lapse and settle at any age (paritytech/dotns#324). Nothing settles them for users, so every unsettled lite name drops out of resolution after a week. It took out 17 of 26 DIM2 bots on paseo-next-v2 on 12 Oct (https://github.com/paritytech/jollity-next/issues/697).How: remove the age filter and the
reservationDuration/Timestamp.Nowreads that only fed it. The resolution path is otherwise unchanged.This is the lapse fix from #1282 on its own. The legacy undotted-claim fallback stays there.