ci: run the required checks on every PR, name them, and shorten PR invariant runs

.github/workflows/deploy-contracts.yml

@@ -3,8 +3,6 @@ name: Deploy Contracts and Verify artifacts
 on:
   pull_request:
     branches: [master]
-    paths:
-      ["contracts/**", "scripts/**", "deployments/**", "**.sol", "package.json", "bun.lock"]
   push:
     branches: [master]
     paths:
@@ -21,7 +19,9 @@ concurrency:
 
 jobs:
   deploy:
+    name: Deploy Contracts
     runs-on: ubuntu-latest
+    timeout-minutes: 30
 
     # Shared across steps. ACCOUNT_* is anvil test account 7 (public test keys,
     # never valid on a real network) used to run the pipeline. FACTORY_DEPLOYER is
@@ -431,8 +431,11 @@ jobs:
         if: always()
         run: pkill -f anvil || true
 
+      # A pull request from a fork gets a read-only token, so posting would fail this check.
       - name: Update PR comment
-        if: always() && github.event_name == 'pull_request'
+        if: >-
+          always() && github.event_name == 'pull_request' &&
+          github.event.pull_request.head.repo.full_name == github.repository
         uses: actions/github-script@v7
         env:
           SECTION: Deploy Contracts

.github/workflows/format-lint-product.yml

@@ -2,7 +2,6 @@ name: Format & Lint
 
 on:
   pull_request:
-    paths: ['src/**', 'script/**', 'test/**', '**.sol']
 
 permissions:
   contents: read
@@ -17,7 +16,9 @@ concurrency:
 
 jobs:
   check:
+    name: Format & Lint
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     steps:
       - uses: actions/checkout@v4
         with:
@@ -64,8 +65,9 @@ jobs:
           path: '*.log'
           retention-days: 7
 
+      # A pull request from a fork gets a read-only token, so posting would fail this check.
       - name: Update PR comment
-        if: always()
+        if: always() && github.event.pull_request.head.repo.full_name == github.repository
         uses: actions/github-script@v7
         env:
           SECTION: Format & Lint

.github/workflows/publish-prerelease.yml

@@ -140,9 +140,13 @@ jobs:
         # build emits. Preserving `cache/` keeps incremental compile fast.
         run: rm -rf out/build-info && forge build --sizes
 
+      # The ci profile, so the released commit gets the same fuzz and invariant campaign as master.
+      # Unit tests and invariants run together here, about two hours, so a stuck run stops at three.
       - name: Run tests
+        timeout-minutes: 180
         env:
           FOUNDRY_DISABLE_NIGHTLY_WARNING: "1"
+          FOUNDRY_PROFILE: "ci"
         run: forge test -vv
 
       # pallet-revive genesis, built from the code this tag ships. Unlike deployments.json

.github/workflows/publish-release.yml

@@ -135,9 +135,13 @@ jobs:
         # build emits. Preserving `cache/` keeps incremental compile fast.
         run: rm -rf out/build-info && forge build --sizes
 
+      # The ci profile, so the released commit gets the same fuzz and invariant campaign as master.
+      # Unit tests and invariants run together here, about two hours, so a stuck run stops at three.
       - name: Run tests
+        timeout-minutes: 180
         env:
           FOUNDRY_DISABLE_NIGHTLY_WARNING: "1"
+          FOUNDRY_PROFILE: "ci"
         run: forge test -vv
 
       # pallet-revive genesis, so a chain can carry dotNS from block zero rather than

.github/workflows/push_checking.yml

@@ -14,7 +14,6 @@ name: Run Solidity Tests
 on:
   pull_request:
     branches: [master]
-    paths: ["contracts/**", "test/**", "**.sol"]
   push:
     branches: [master]
     paths: ["contracts/**", "test/**", "**.sol"]
@@ -35,6 +34,7 @@ jobs:
     if: github.event.action != 'closed'
     name: ${{ matrix.kind.label }}
     runs-on: ubuntu-latest
+    timeout-minutes: ${{ matrix.kind.timeout[github.event_name] }}
     strategy:
       # Each matrix kind runs on its own runner so neither has to hold the
       # other's peak memory. Don't fail-fast: surfacing both shards' results
@@ -45,9 +45,13 @@ jobs:
           - id: unit-fuzz
             label: Contract Tests (Unit + Fuzz)
             forge_args: --no-match-contract Invariant --no-match-path 'test/fork/**'
+            timeout: { pull_request: 30, push: 30 }
           - id: invariant
             label: Contract Tests (Invariant)
             forge_args: --match-contract Invariant --no-match-path 'test/fork/**'
+            # Pull requests run 100 invariant runs per campaign (about 30 minutes), master 300
+            # (about 100 minutes).
+            timeout: { pull_request: 60, push: 150 }
     steps:
       - uses: actions/checkout@v4
         with:
@@ -145,6 +149,14 @@ jobs:
             exit 1
           fi
 
+          # Pull requests run 100 invariant runs per campaign to keep the check short; pushes to
+          # master keep the ci profile's 300. No seed is fixed, so every run explores new
+          # sequences. The unit + fuzz leg runs no invariants, so this only affects the invariant
+          # leg.
+          if [ "$GITHUB_EVENT_NAME" = "pull_request" ]; then
+            export FOUNDRY_INVARIANT_RUNS=100
+          fi
+
           forge test -vv --summary ${{ matrix.kind.forge_args }} 2>&1 | tee test.log
           TEST=${PIPESTATUS[0]}
 
@@ -206,8 +218,13 @@ jobs:
   report:
     name: Report Test Results
     needs: test
-    if: always() && github.event_name == 'pull_request' && github.event.action != 'closed'
+    # A pull request from a fork gets a read-only token, so publishing the reports and the comment
+    # would fail.
+    if: >-
+      always() && github.event_name == 'pull_request' && github.event.action != 'closed' &&
+      github.event.pull_request.head.repo.full_name == github.repository
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
 
@@ -330,6 +347,7 @@ jobs:
 
   cleanup:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     if: github.event.action == 'closed'
     steps:
       - uses: actions/checkout@v4

.github/workflows/release-metadata.yml

@@ -10,15 +10,6 @@ on:
     # Includes labeled and unlabeled so adding `deployment-record` re-runs the manifest guard
     # below. Listing types at all replaces the default set, so the defaults are repeated here.
     types: [opened, edited, synchronize, reopened, labeled, unlabeled, ready_for_review]
-    # A pull request touching none of the paths below never starts this workflow, so no job in
-    # it reports a conclusion on that pull request. Harmless while these are optional checks,
-    # and the thing to settle before marking any of them required: a required check that never
-    # reports blocks the merge.
-    paths:
-      - "deployments/**"
-      - ".github/abi-contracts.txt"
-      - "scripts/js/release-metadata.mjs"
-      - ".github/workflows/release-metadata.yml"
 
 permissions:
   contents: read
@@ -32,7 +23,9 @@ concurrency:
 
 jobs:
   validate:
+    name: Release Metadata
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
 
@@ -53,7 +46,9 @@ jobs:
   # reports no conclusion, so making this a required check would leave a correctly labelled
   # deploy pull request unable to merge. The label is read inside the step instead.
   live-manifests-unchanged:
+    name: Live Manifests Unchanged
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
         with:

.github/workflows/secret-scan.yml

@@ -24,7 +24,9 @@ env:
 
 jobs:
   scan:
+    name: Secret Scan
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
         with:
@@ -94,8 +96,11 @@ jobs:
           retention-days: 7
           if-no-files-found: ignore
 
+      # A pull request from a fork gets a read-only token, so posting would fail this check.
       - name: Update PR comment
-        if: always() && github.event_name == 'pull_request'
+        if: >-
+          always() && github.event_name == 'pull_request' &&
+          github.event.pull_request.head.repo.full_name == github.repository
         uses: actions/github-script@v7
         env:
           SECTION: Secret Scan

.github/workflows/validate-files.yml

@@ -22,6 +22,7 @@ jobs:
   validate:
     name: File Validation
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4