Repository navigation
feat(cli): follow the dotNS v1.0.0 contracts - #329
Conversation
CI Summary
Release - PassedTest this PR Download artifact (GitHub CLI required): gh run download 37445600365 -n cli-release-0.0.0-pr.329 -R paritytech/dotns-sdkInstall globally: npm install -g ./parity-dotns-cli-0.0.0-pr.329.tgzVerify: dotns --helpDeploy Example — Passed
Labelspkg: cli, scope: bulletin, type: docs, type: test, dependencies Test - Passed388 passed, 0 failed across 388 tests. |
|
With the friction charge gone, It probably also makes sense to read the registrar's |
charlesHetterich
left a comment
There was a problem hiding this comment.
LGTM, just the above comment
# Conflicts: # packages/cli/src/commands/escrow.ts # packages/cli/src/commands/register.ts
…from the registrar
Done in fd51ccb : |
Description
Follows dotNS v1.0.0 while staying compatible with v0.8.0. Deployments older than v0.8.0 are no longer supported.
PopRules,DotnsPopControllerandDotnsPopResolverchanged, and the CLI calls none of their changed functions.josephbeneath42). The pre-v0.7.0 flat-node fallback is removed.register --transferno longer callssyncLabel, which no contract version has.register()charges.DotnsRegistry.owner, so device names work and missing names report "has no owner".StringUtils.MAX_NAME_PATH_OCTETS..github/PULL_REQUEST_TEMPLATE.mdand.github/CONTRIBUTING.mdlose a trailing space in their names, so GitHub picks them up.Type
Package
@parity/dotns-cliRelated Issues
paritytech/dotns#319
Fixes
Checklist
Code
bun run lintpassesbun run formatpassesbun run typecheckpassesDocumentation
Breaking Changes
Breaking changes:
ProofOfPersonhoodStatus.ProofOfPersonhoodLite/ProofOfPersonhoodFullbecomeDevicehood/Personhood(same values).dotns pop status --jsonreportsdevicehood/personhood(waslite/full);statusCodeis unchanged.transferNamedrops its options argument, andTransferNameOptionsis removed.RegistrationResultdropsfrictionWeiandchargedWei;RegisterNameOptionsdropscallerAddress;finalizeRegularRegistrationdrops its friction argument.LiteNameReservedevents.Testing
How to test:
bun run --cwd packages/cli test:unit(375 pass)dotns lookup name joseph.42 --env paseo-v2 --json.Notes
On v0.8.0 chains, the CLI's pre-checks use v1.0.0 wording, while contract reverts keep their own text.