Skip to content

fix(cli): refuse to sign with the shared dev account unless opted in - #320

Merged
re-gius merged 5 commits into
mainfrom
fix/dev-account-fail-closed
Oct 14, 2026
Merged

re-gius merged 5 commits into
mainfrom
fix/dev-account-fail-closed

Conversation

@charlesHetterich

Copy link
Copy Markdown
Contributor

Description

  • Write commands now fail when nothing but the built-in default mnemonic resolves, instead of signing with the public dev account and warning. --allow-dev-account or DOTNS_ALLOW_DEV_ACCOUNT=1 opts back in (still warns). The README already documented this refusal; the code only warned.
  • The dev-account and --mnemonic-on-argv warnings are written through a stderr binding taken before the --json console capture, so they reach stderr in machine-readable runs while stdout stays clean JSON.
  • Read-only commands (pop status, lookup, …) now say on stderr when they are reporting on the dev account; they never warned before.

Type

  • Bug fix
  • Breaking change

Package

  • @parity/dotns-cli

Fixes

Fixes paritytech/dotns#292

Checklist

Code

  • Follows project style
  • bun run lint passes
  • bun run format passes
  • bun run typecheck passes

Documentation

  • README updated if needed
  • Types updated if needed

Breaking Changes

  • Breaking changes documented below

Breaking changes: a write command with no key configured (no flags, no DOTNS_MNEMONIC / DOTNS_KEY_URI, no keystore) now exits 1 with No signing account configured — refusing to sign with the shared public dev account. Scripts that relied on the implicit dev account must pass --allow-dev-account or set DOTNS_ALLOW_DEV_ACCOUNT=1. Read-only commands are unaffected.

Testing

cd packages/cli && bun test tests/unit/

353 pass, 0 fail.

With a clean HOME and no DOTNS_MNEMONIC / DOTNS_KEY_URI set, against paseo-v2:

bun run dev store claim --env paseo-v2 --json

exit 1, stdout empty, stderr {"error":"No signing account configured — refusing to sign with the shared public dev account. …"}.

DOTNS_ALLOW_DEV_ACCOUNT=1 bun run dev store claim --env paseo-v2 --json

proceeds; stderr ⚠ Signing with the shared public dev account that anyone can control., stdout clean JSON.

bun run dev pop status --env paseo-v2 --json

exit 0, stdout unchanged JSON, stderr ⚠ No account configured — reporting on the shared public dev account. (was 0 bytes).

Version bumped to 0.10.0 for the release guard.

charlesHetterich and others added 2 commits October 14, 2026 11:34
Write commands now fail when nothing but the built-in default mnemonic
resolves; --allow-dev-account or DOTNS_ALLOW_DEV_ACCOUNT=1 opts back in.
The dev-account and argv-secret warnings are written through a stderr
binding taken before the --json console capture, so they stay visible in
machine-readable runs, and read-only commands now say when they are
reporting on the dev account.
@re-gius
re-gius force-pushed the fix/dev-account-fail-closed branch from 60be5ce to 9724b4e Compare October 14, 2026 09:38
@re-gius
re-gius marked this pull request as ready for review October 14, 2026 09:38
@re-gius
re-gius requested a review from a team as a code owner October 14, 2026 09:38
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

CI Summary

Check Result
Lint Passed
Format Passed
Typecheck Passed
Build Passed
Release Passed
Deploy Example Passed
PR Title Passed
Labels Passed
Test Passed - 395 passed, 0 failed

Release - Passed

Test this PR

Download artifact (GitHub CLI required):

gh run download 38551963185 -n cli-release-0.0.0-pr.320 -R paritytech/dotns-sdk

Install globally:

npm install -g ./parity-dotns-cli-0.0.0-pr.320.tgz

Verify:

dotns --help
Deploy Example — Passed
Stage Status
✓ Site validation Site validated
✓ Deploy Deployed (cached)
Property Value
Domain pr320.dotns-example-site.dot
CID bafybeicx555prsudvmqsdrap7keoilryrudwycdx3ody2rejwqwjwp52u4 (cached)
URL (dot.li) https://pr320.dotns-example-site.dot.li
URL (paseo.li) https://pr320.dotns-example-site.paseo.li
URL (direct) https://pr320.dotns-example-site.dot
Duration 35s

View run

Labels

pkg: cli, type: docs, type: test, dependencies

Test - Passed

395 passed, 0 failed across 395 tests.

View run

$ bun test tests/unit/
bun test v1.2.6 (8ebd5d53)

::group::tests/unit/store/storeHelp.test.ts:
(pass) store --help lists subcommands [13.00ms]
(pass) store claim --help shows description and auth options [3.00ms]
(pass) store info --help shows auth options [3.00ms]
(pass) store list --help shows options [2.00ms]
(pass) store get --help shows key argument [2.00ms]
(pass) store set --help shows key and value arguments with auth [2.00ms]
(pass) store delete --help shows key argument with auth [2.00ms]

::endgroup::

::group::tests/unit/inspect/prechecks.test.ts:
(pass) releaseName refuses before the approve > a name that is not registered [2.00ms]
(pass) releaseName refuses before the approve > a subname or device name, which has no registrar token [1.00ms]
(pass) releaseName refuses before the approve > a soulbound personhood name
(pass) releaseName refuses before the approve > a failed soulbound read, which aborts the release [1.00ms]
(pass) releaseName refuses before the approve > a name with no escrow position
(pass) releaseName refuses before the approve > a name already released, saying until when the holder may redeem [1.00ms]
(pass) releaseName refuses before the approve > a released name whose deposit was withdrawn, saying nobody can redeem it
(pass) releaseName refuses before the approve > a name owned by another account [1.00ms]
(pass) releaseName refuses before the approve > otherwise approves the escrow and then releases
(pass) transferName refuses before the write > a subname or device name, which has no registrar token
(pass) transferName refuses before the write > a soulbound personhood name [1.00ms]
(pass) transferName refuses before the write > a name owned by another account
(pass) transferName refuses before the write > otherwise submits the transfer
(pass) ensureDomainNotRegistered > explains a name inside its redeem window and when registration opens [1.00ms]
(pass) ensureDomainNotRegistered > says only when registration opens once the deposit was withdrawn
(pass) ensureDomainNotRegistered > does not mention a redeem window for a held, unreleased name

::endgroup::

::group::tests/unit/utils/validation.test.ts:
(pass) normaliseLabel > lowercases, trims, and strips a single trailing .dot
(pass) normaliseLabel > strips the given TLD suffix
(pass) isSecondLevelDotName > distinguishes a second-level name from a subdomain under the given TLD
(pass) isCanonicalLabel > accepts lowercase letters, digits and internal hyphens
(pass) isCanonicalLabel > rejects dots, uppercase, spaces and other characters
(pass) isCanonicalLabel > rejects leading or trailing hyphens, empty and overlong labels
(pass) isSecondLevelDotName > accepts a single label, with or without the .dot suffix
(pass) isSecondLevelDotName > rejects subdomains
(pass) validateCanonicalLabel > throws for a name containing a dot, naming the role
(pass) validateCanonicalLabel > does not throw for a canonical label
(pass) validateDomainLabel trailing digits > accepts labels with no trailing digits
(pass) validateDomainLabel trailing digits > accepts a two-digit suffix
(pass) validateDomainLabel trailing digits > accepts labels with any trailing digit count
(pass) validateDomainLabel trailing digits > rejects labels shorter than three characters
(pass) validateDomainLabel trailing digits > rejects labels with uppercase characters
(pass) validateDomainLabel trailing digits > rejects labels with leading or trailing hyphen
(pass) validateGovernanceLabel base-length rule > accepts base names of five characters or fewer
(pass) validateGovernanceLabel base-length rule > rejects base names longer than five characters
(pass) validateGovernanceLabel base-length rule > measures an ordinary label whole, digits included
(pass) validateGovernanceLabel measures the base name as PopRules does > accepts any digit count while the whole label stays within the reserved band
(pass) validateGovernanceLabel measures the base name as PopRules does > rejects once the label as written leaves the reserved band
(pass) validateGovernanceLabel measures the base name as PopRules does > the NORMAL path accepts any digit count too
(pass) validateGovernanceLabel canonical-label rules > rejects uppercase characters
(pass) validateGovernanceLabel canonical-label rules > rejects labels containing a dot
(pass) validateGovernanceLabel canonical-label rules > rejects leading or trailing hyphen
(pass) validateGovernanceLabel canonical-label rules > rejects labels shorter than three characters
(pass) isPersonhoodLabel > accepts a letters-only name [1.00ms]
(pass) isPersonhoodLabel > rejects digits, hyphens, uppercase and the empty string
(pass) isDeviceLabel > accepts a letters-only stem, one separator and exactly two digits
(pass) isDeviceLabel > rejects a stem the gateway pallet could not have issued
(pass) isDeviceLabel > rejects any other digit count or a missing separator
(pass) baseLabelOf > drops the separator and allocated digits from a device label
(pass) baseLabelOf > measures an ordinary label whole
(pass) isSecondLevelDotName with a device name > treats a device name as a single second-level name
(pass) isSecondLevelDotName with a device name > still treats a real subname as a subdomain
(pass) device names on the registration path > validateDomainLabel refuses a device name with the gateway pallet reason
(pass) device names on the registration path > a shape the gateway pallet cannot issue still gets the charset error
(pass) validateExistingNameLabel > accepts a device name
(pass) validateExistingNameLabel > accepts an ordinary label
(pass) validateExistingNameLabel > still rejects a subname and other malformed input
(pass) validateParentPath > accepts a path at the bound
(pass) validateParentPath > rejects a path one octet over the bound, naming its length
(pass) validateParentPath > accepts ordinary and device-name parents

::endgroup::

::group::tests/unit/utils/contractInteractions.test.ts:
(pass) deriveDomainNode > matches namehashUnder(tldNode, labelhash)
(pass) deriveDomainNode > different TLDs yield different nodes for the same label
(pass) deriveDomainNode > folds a subname per label from the TLD node
(pass) deriveDomainNode > agrees with viem's namehash of the fully qualified name [1.00ms]
(pass) deriveDomainNode > folds a device name beneath its numeric container
(pass) deriveDomainTokenId > is uint256(node) [1.00ms]
(pass) deriveDomainTokenId > known vector: getsome under .dot
(pass) isRevertFlag matches the EVM revert bit > flags=0n gives false
(pass) isRevertFlag matches the EVM revert bit > flags=1n gives true
(pass) isRevertFlag matches the EVM revert bit > flags=2n gives false
(pass) isRevertFlag matches the EVM revert bit > flags=3n gives true
(pass) buildRevertError > empty data names both the unmapped-origin and stale-ABI causes
(pass) buildRevertError > known ABI selector decodes to the named error [2.00ms]
(pass) buildRevertError > unknown selector falls back to raw hex [1.00ms]
(pass) decodeContractRevertError > empty data includes operation context
(pass) decodeContractRevertError > non-empty data decodes against the ABI [1.00ms]

::endgroup::

::group::tests/unit/account/accountHelp.test.ts:
(pass) account --help lists subcommands including is-mapped and grant [3.00ms]
(pass) account is-mapped --help shows address argument and --json [2.00ms]
(pass) account grant --help shows label argument and --json [2.00ms]

::endgroup::

::group::tests/unit/delegate/delegateHelp.test.ts:
(pass) delegate --help lists set, revoke, status, records and auth options [6.00ms]
(pass) delegate records --help shows operator argument and --revoke [3.00ms]
(pass) delegate records-status --help shows operator argument and --json [2.00ms]
(pass) delegate set --help shows name and delegate arguments [2.00ms]
(pass) delegate revoke --help shows name argument [3.00ms]
(pass) delegate status --help shows name argument and --json [2.00ms]

::endgroup::

::group::tests/unit/auth/resolveAuthSourceReadOnly.test.ts:
(pass) resolveAuthSourceReadOnly honours environment variables > $label [1.00ms]
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label

::endgroup::

::group::tests/unit/auth/authRevert.test.ts:
(pass) auth set rejects account name with forward slash [4.00ms]
(pass) auth set rejects account name with backslash [1.00ms]
(pass) auth set rejects account name that is just a dot [1.00ms]
(pass) auth set rejects account name that is double dots [3.00ms]
(pass) auth set rejects account name starting with dot [2.00ms]
(pass) auth set rejects account name ending with dot [2.00ms]
(pass) auth set rejects account name with special characters [10.00ms]
(pass) auth set rejects account name that is too long [2.00ms]
(pass) auth use rejects non-existent account [74.00ms]
(pass) auth remove rejects non-existent account [57.00ms]

::endgroup::

::group::tests/unit/auth/authHelp.test.ts:
(pass) root help lists auth command [3.00ms]
(pass) auth help shows options and subcommands [2.00ms]
(pass) auth set help shows all options [1.00ms]
(pass) auth list help shows options [2.00ms]
(pass) auth use help shows options [1.00ms]
(pass) auth remove help shows options [1.00ms]
(pass) auth clear help shows options [1.00ms]
(pass) auth parses keystore-path option [2.00ms]
(pass) auth parses password option [1.00ms]
(pass) auth set parses account option [2.00ms]
(pass) auth set parses mnemonic option [2.00ms]
(pass) auth set parses key-uri option [1.00ms]
(pass) auth help command shows help [2.00ms]
(pass) auth help set shows set command help [2.00ms]
(pass) auth help list shows list command help [1.00ms]
(pass) auth help use shows use command help [2.00ms]
(pass) auth help remove shows remove command help [1.00ms]
(pass) auth help clear shows clear command help [2.00ms]

::endgroup::

::group::tests/unit/auth/auth.test.ts:
(pass) auth set creates keystore and stores multiple accounts [240.00ms]
(pass) auth set accepts account names with special characters [336.01ms]
(pass) auth list reports missing keystore [5.00ms]
(pass) auth list shows all accounts and auth types [220.01ms]
(pass) auth use switches default account [321.01ms]
(pass) auth remove last account clears default [59.00ms]
(pass) auth remove preserves remaining accounts and reassigns default [179.00ms]
(pass) auth clear deletes all accounts [61.00ms]
(pass) resolveAuthSource prefers selected keystore account over ambient env mnemonic [175.00ms]
(pass) resolveAuthSource resolves from env mnemonic when only the default keystore path is given
(pass) resolveAuthSource prefers selected keystore account over ambient env key URI [116.00ms]
(pass) auth set rejects weak password supplied by flag for new keystore [5.00ms]
(pass) auth set rejects weak password supplied by env for new keystore [2.00ms]
(pass) resolveAuthSource default branch carries the dev credential for the retry cache [1.00ms]

::endgroup::

::group::tests/unit/primary/primaryHelp.test.ts:
(pass) primary --help lists set, status and auth options [2.00ms]
(pass) primary set --help shows name argument and --json [1.00ms]
(pass) primary status --help shows optional address argument and --json [1.00ms]

::endgroup::

::group::tests/unit/client/storageDepositLimit.test.ts:
(pass) computeStorageDepositLimit > floors at two whole tokens for 10 decimals
(pass) computeStorageDepositLimit > floors at two whole tokens for 12 decimals
(pass) computeStorageDepositLimit > keeps the floor when the buffered estimate is below it
(pass) computeStorageDepositLimit > uses the estimate plus 20% once it exceeds the floor
(pass) ReviveClientWrapper token info > defaults to DEFAULT_NATIVE_TOKEN_DECIMALS and DEFAULT_NATIVE_TOKEN_SYMBOL
(pass) ReviveClientWrapper token info > rejects non-integer and negative decimals
(pass) ReviveClientWrapper token info > rejects an empty symbol
(pass) ReviveClientWrapper token info > createDotnsContext reads token info from the wrapper [2.00ms]
(pass) submitTransaction storage_deposit_limit > applies the connected chain's two-token floor
(pass) submitTransaction storage_deposit_limit > derives the limit from the dry run when it exceeds the floor

::endgroup::

::group::tests/unit/client/chainTokenInfo.test.ts:
(pass) getChainTokenInfo > reads scalar properties
(pass) getChainTokenInfo > reads the first entry of array properties
(pass) getChainTokenInfo > accepts decimals encoded as a digit string
(pass) getChainTokenInfo > falls back to the defaults with a warning when properties are missing
(pass) getChainTokenInfo > falls back to the default decimals for ""
(pass) getChainTokenInfo > falls back to the default decimals for null
(pass) getChainTokenInfo > falls back to the default decimals for true [1.00ms]
(pass) getChainTokenInfo > falls back to the default decimals for -1
(pass) getChainTokenInfo > falls back to the default decimals for 1.5
(pass) getChainTokenInfo > falls back to the default decimals for "1.5"
(pass) getChainTokenInfo > falls back to the default decimals for []
(pass) getChainTokenInfo > falls back to the default symbol for an empty string

::endgroup::

::group::tests/unit/register/subnodePersist.test.ts:
(pass) registerSubnode encodes the persist flag > persists into the owner's store by default [1.00ms]
(pass) registerSubnode encodes the persist flag > skips store indexing when persist is disabled [1.00ms]
(pass) registerSubnode bounds the parent path > rejects a parent path over the bound, before writing

::endgroup::

::group::tests/unit/register/eligibility.test.ts:
(pass) getPriceAndValidateEligibility > a personhood-band name refuses a devicehood holder with the PopRules reason
(pass) getPriceAndValidateEligibility > a personhood holder passes the personhood band
(pass) getPriceAndValidateEligibility > a device name is refused before any pricing read [1.00ms]
(pass) getPriceAndValidateEligibility > a base name reserved for another account names the device-name claim

::endgroup::

::group::tests/unit/register/registrationManifest.test.ts:
(pass) registration manifest persistence > saves a record and reads it back by label [52.00ms]
(pass) registration manifest persistence > stores the sealed pricing fields losslessly as decimal strings [50.00ms]
(pass) registration manifest persistence > encrypts the secret at rest (never stored in plaintext) [58.00ms]
(pass) registration manifest persistence > decrypts the secret with the correct credential [101.00ms]
(pass) registration manifest persistence > rejects decryption with the wrong credential [108.00ms]
(pass) registration manifest persistence > lists records for the env + caller, newest commit first [98.00ms]
(pass) registration manifest persistence > isolates records by env and caller [113.00ms]
(pass) registration manifest persistence > deletes a record [50.00ms]
(pass) registration manifest persistence > returns empty when nothing is cached
(pass) registration manifest persistence > clear record selection scopes to a requested label [99.00ms]
(pass) registration manifest persistence > clear record selection errors when a requested label is missing [57.00ms]
(pass) resolveManifestCredential > prefers password, then mnemonic, then key URI
(pass) resolveManifestCredential > returns null when no credential is available
(pass) resolveManifestCredential > uses env mnemonic and key URI for registration cache encryption
(pass) TLD ingested from chain > resolveTldInfo reads the deployment TLD
(pass) TLD ingested from chain > retries a transient read failure before resolving [302.01ms]
(pass) TLD ingested from chain > the immutable TLD is cached across calls
(pass) TLD ingested from chain > does not share the cache between clients that share a controller address
(pass) TLD ingested from chain > computeDomainTokenId derives the id under the chain TLD [1.00ms]
(pass) TLD ingested from chain > formatDomainName uses the deployment TLD suffix
(pass) ensureDomainNotRegistered enforces the controller predicate > passes when available(label) is true, checking available not ownerOf
(pass) ensureDomainNotRegistered enforces the controller predicate > throws with the real TLD suffix when available(label) is false

::endgroup::

::group::tests/unit/register/registerOwnerConflicts.test.ts:
(pass) register domain rejects --owner with --transfer [3.00ms]
(pass) register domain rejects --owner with --reverse [2.00ms]
(pass) register domain rejects --owner with --governance [2.00ms]

::endgroup::

::group::tests/unit/register/registerJson.test.ts:
(pass) register domain --help shows --json option [2.00ms]
(pass) register subname --help shows --json option [1.00ms]
(pass) register domain --json emits JSON error when --transfer without --to [1.00ms]

::endgroup::

::group::tests/unit/register/registerHelp.test.ts:
(pass) root help lists register command [3.00ms]
(pass) register help shows subcommands [1.00ms]
(pass) register domain help shows options [1.00ms]
(pass) register subname help shows options [2.00ms]
(pass) register domain parses reverse flag [2.00ms]
(pass) register domain parses governance flag [1.00ms]
(pass) register domain parses owner option [2.00ms]
(pass) register domain parses transfer with destination [1.00ms]
(pass) register domain parses account option [2.00ms]
(pass) register domain parses keystore-path option [2.00ms]
(pass) register domain parses password option [1.00ms]
(pass) register domain parses mnemonic option [2.00ms]
(pass) register domain parses key-uri option [2.00ms]
(pass) register domain parses commitment-buffer option [1.00ms]
(pass) register domain parses commitment-buffer alias --cb [2.00ms]
(pass) register subname parses name and parent [2.00ms]
(pass) register subname parses owner option [2.00ms]
(pass) getCommitmentBufferSeconds defaults to 6 when env is not set
(pass) getCommitmentBufferSeconds reads from DOTNS_COMMITMENT_BUFFER env variable
(pass) COMMITMENT_POLL_INTERVAL_MS is 2000
(pass) COMMITMENT_POLL_TIMEOUT_MS is 30000

::endgroup::

::group::tests/unit/pop/setPopHelp.test.ts:
(pass) root help lists pop command [3.00ms]
(pass) pop help shows commands and description [1.00ms]
(pass) pop help shows auth options [1.00ms]
(pass) pop info help shows description [2.00ms]
(pass) pop status help shows description [1.00ms]
(pass) pop info help shows auth options [1.00ms]
(pass) pop info parses auth options at pop level [1.00ms]
(pass) pop info parses auth options at info level [2.00ms]
(pass) pop help command shows pop help [1.00ms]
(pass) pop help status shows info help [1.00ms]
(pass) pop help info shows info help [1.00ms]

::endgroup::

::group::tests/unit/pop/popJson.test.ts:
(pass) pop info --help shows --json option [2.00ms]
(pass) pop status --help shows --json option [1.00ms]

::endgroup::

::group::tests/unit/lookup/lookupHelp.test.ts:
(pass) lookup --help lists subcommands and auth options [2.00ms]
(pass) lookup name --help shows label argument and options [1.00ms]
(pass) lookup owner-of --help shows label argument and options [2.00ms]
(pass) lookup transfer --help shows label argument and destination option [1.00ms]
(pass) lookup transfer parses destination at transfer level [2.00ms]
(pass) lookup transfer parses auth options at lookup level [1.00ms]

::endgroup::

::group::tests/unit/lookup/lookupNormalisation.test.ts:
(pass) lookup normalises fully-qualified names > performDomainLookup derives the same node for `alice` and `alice.paseo` [1.00ms]
(pass) lookup normalises fully-qualified names > performOwnerOfLookup derives the same node for `alice` and `alice.paseo`
(pass) lookup normalises fully-qualified names > a name under a different suffix is not stripped [1.00ms]
(pass) device names resolve at their folded subnode > a registered device name resolves as its stem beneath the numeric container
(pass) device names resolve at their folded subnode > an unregistered device name reports its folded node and no record [1.00ms]
(pass) lookup folds subnames per label > performDomainLookup queries the EIP-137 node of `blog.alice`
(pass) lookup folds subnames per label > `blog.alice` and `blog.alice.paseo` resolve to the same node [1.00ms]
(pass) lookup folds subnames per label > performOwnerOfLookup reads the registry owner, so a subname reports its holder
(pass) lookup folds subnames per label > performOwnerOfLookup reports an unregistered name as such

::endgroup::

::group::tests/unit/escrow/escrowHelp.test.ts:
(pass) root help lists escrow command [2.00ms]
(pass) escrow help shows the subcommand description and subcommands [2.00ms]
(pass) escrow balance help describes the claimable pull-payment balance [1.00ms]
(pass) escrow positions help describes the list and total [1.00ms]
(pass) escrow status help describes the read-only position lookup [1.00ms]
(pass) escrow release help describes the approve-and-release sequence [1.00ms]
(pass) escrow redeem help describes taking a released name back [1.00ms]
(pass) escrow withdraw help describes the post-cooldown step [2.00ms]
(pass) escrow claim-withdrawal help describes the overpayment ledger [1.00ms]
(pass) escrow refunds help lists list/claim/claim-batch [1.00ms]
(pass) escrow refunds list help exposes pagination options [1.00ms]
(pass) escrow refunds claim help requires an entry id positional [1.00ms]
(pass) escrow refunds claim-batch help accepts variadic ids [2.00ms]

::endgroup::

::group::tests/unit/escrow/escrowFormatting.test.ts:
(pass) formatRefundEntryLine > marks entries past their cooldown as claimable [1.00ms]
(pass) formatRefundEntryLine > marks entries inside their cooldown window with remaining seconds [1.00ms]
(pass) formatRefundEntryLine > renders the amount in the chain's native token symbol
(pass) formatRefundEntryLine > truncates large tokenIds for terminal display
(pass) totalEscrowAmount > is zero for no positions
(pass) totalEscrowAmount > sums position amounts
(pass) isRefundableDeposit > is true only when the position holds an amount
(pass) cooldownRemainingSeconds > returns the seconds left, clamped to zero once elapsed
(pass) formatCooldown > formats seconds and minutes
(pass) formatPositionStatus > held when not released
(pass) formatPositionStatus > embeds the cooldown countdown while released and waiting
(pass) formatPositionStatus > claimable once the cooldown elapses
(pass) formatPositionStatus > claimed after withdrawal
(pass) releasePhase > held while the name is not released
(pass) releasePhase > redeemable while released, unwithdrawn and inside the window
(pass) releasePhase > awaiting when the deposit was withdrawn inside the window
(pass) releasePhase > reclaimable once the window elapses, matching the escrow's isReclaimable
(pass) formatReleasePhase > names the phase and the time it changes
(pass) formatPositionsTable > returns no lines for an empty set
(pass) formatPositionsTable > renders a header plus one aligned row per position with the phase and cooldown
(pass) pendingRefunds multi-output decode > decodes to a [ids, entries] tuple [1.00ms]
(pass) pendingRefunds multi-output decode > decodes an empty ledger to a pair of empty arrays [1.00ms]

::endgroup::

::group::tests/unit/escrow/redeem.test.ts:
(pass) redeemName refuses before the write > a name that was never released [1.00ms]
(pass) redeemName refuses before the write > a caller who is not the previous holder
(pass) redeemName refuses before the write > a closed redeem window, saying when it closed
(pass) redeemName refuses before the write > a deposit already withdrawn inside the window
(pass) redeemName refuses before the write > otherwise submits redeem for the token

::endgroup::

::group::tests/unit/cli/paseoCreate3Addresses.test.ts:
(pass) paseo-v2 uses the canonical fresh-deploy address book
(pass) previewnet shares the whole paseo-v2 book
(pass) devnet keeps its own distinct deployment

::endgroup::

::group::tests/unit/cli/bulletinRpc.test.ts:
(pass) paseo-v2 default resolves to the existing bulletin RPC
(pass) explicit argument wins over env var and active env
(pass) env var wins over active env config when no explicit argument [1.00ms]
(pass) falls back to active env's bulletin RPC
(pass) throws when nothing is configured (synthetic case)
(pass) bulletin cache Asset Hub RPC uses merged CLI rpc before DOTNS_RPC
(pass) bulletin cache Asset Hub RPC uses selected environment when no rpc override exists
(pass) bulletin cache rejects custom Bulletin env override without matching target
(pass) bulletin cache accepts custom Bulletin override with explicit environment
(pass) bulletin cache custom Bulletin with DOTNS_ENV ignores stale DOTNS_RPC
(pass) bulletin cache accepts custom Bulletin override with explicit Asset Hub RPC

::endgroup::

::group::tests/unit/cli/environment.test.ts:
(pass) defaults to paseo-v2
(pass) accepts friendly paseo-v2 aliases
(pass) DOTNS_ENV selects rpc and contract set
(pass) --env takes precedence over DOTNS_ENV while --rpc only overrides endpoint
(pass) printCommandHeader emits one contextual line with version, action, target and network [1.00ms]

::endgroup::

::group::tests/unit/cli/authOptions.test.ts:
(pass) getAuthOptions resolves a global --env given before a two-level-nested command
(pass) getAuthOptions lets a command-level --env override the global one
(pass) getAuthOptions resolves the --network alias from the program root

::endgroup::

::group::tests/unit/cli/devAccountGuard.test.ts:
(pass) assertSigningAccountConfigured > accepts every source other than the built-in default
(pass) assertSigningAccountConfigured > refuses the default source and points at the opt-in
⚠  Signing with the shared public dev account that anyone can control.
(pass) assertSigningAccountConfigured > proceeds once the caller opts in
(pass) security warnings survive the --json capture > writeSecurityWarning reaches stderr from inside withCapturedConsole [79.00ms]
• Resolving account
✓ Resolving account
(pass) resolveSigningAuth > refuses when nothing but the default resolves
• Resolving account
✓ Resolving account
⚠  Signing with the shared public dev account that anyone can control.
(pass) resolveSigningAuth > reads the --allow-dev-account option
• Resolving account
✓ Resolving account
⚠  Signing with the shared public dev account that anyone can control.
(pass) resolveSigningAuth > reads DOTNS_ALLOW_DEV_ACCOUNT=1 [1.00ms]

::endgroup::

::group::tests/unit/cli/qrSigner.test.ts:
⚠ The QR mobile-wallet signer is experimental and still in development; expect rough edges.
(pass) createQrSigner > throws a clear error when no global WebSocket is available [1.00ms]
⚠ The QR mobile-wallet signer is experimental and still in development; expect rough edges.
Approve the signing allowance on your phone to continue.
(pass) createQrSigner > returns the SS58 origin derived from the paired signer's public key

::endgroup::

::group::tests/unit/cli/transfer.test.ts:
(pass) resolveTransferRecipient > returns a raw EVM address in checksummed form without touching the chain
(pass) resolveTransferRecipient > rejects input that is neither an EVM address, SS58 address, nor domain name

::endgroup::

::group::tests/unit/cli/assertExpectedChain.test.ts:
(pass) assertExpectedChain > passes when the chain reports the environment's genesis [1.00ms]
(pass) assertExpectedChain > fails naming both chains on a mismatch
(pass) assertExpectedChain > hash comparison is case-insensitive
(pass) assertExpectedChain > a null pinned hash skips the check
(pass) assertExpectedChain > a bulletin mismatch points at the bulletin knobs
(pass) assertExpectedChain > the escape hatch bypasses the check
(pass) assertExpectedChain > a known chain is named in the error alongside its hash
(pass) assertExpectedChain > the bulletin connection is checked against the bulletin genesis
(pass) assertExpectedChain > the caller can inject the environment

::endgroup::

::group::tests/unit/cli/dotliViewUrls.test.ts:
(pass) paseo-v2 emits only its paseo.li gateway
(pass) devnet emits only its dev-dot.li gateway
(pass) previewnet emits no dot.li gateway
(pass) passes the label through unchanged, so the TLD is never duplicated

::endgroup::

::group::tests/unit/cli/transferRecipient.test.ts:
(pass) resolveTransferRecipient with a name > a device name resolves to the registry owner of its folded node
(pass) resolveTransferRecipient with a name > an ordinary label resolves through the same registry read [1.00ms]
(pass) resolveTransferRecipient with a name > an unregistered name reports it has no owner

::endgroup::

::group::tests/unit/cli/signerKind.test.ts:
(pass) resolveSignerKind > defaults to keystore
(pass) resolveSignerKind > reads DOTNS_SIGNER=qr
(pass) resolveSignerKind > an explicit flag overrides the env var
(pass) resolveSignerKind > an unknown value falls back to keystore
(pass) resolveQrAppId > defaults to the unified product id
(pass) resolveQrAppId > flag beats env beats default [1.00ms]
(pass) resolveQrPeopleEndpoints > defaults to the paseo stage
(pass) resolveQrPeopleEndpoints > resolves named stages
(pass) resolveQrPeopleEndpoints > treats a non-stage value as a comma-separated wss list
(pass) resolveQrPeopleEndpoints > rejects a non-wss URL
(pass) resolveQrPeopleEndpoints > rejects an empty/blank value
(pass) resolveQrPeopleEndpoints > rejects a wss URL with embedded credentials
(pass) resolveQrPeopleEndpoints > flag beats env beats default
(pass) assertSignerOptions > keystore signer allows local-account flags
(pass) assertSignerOptions > qr signer with no local flags is allowed
(pass) assertSignerOptions > qr signer rejects a local-account flag
(pass) assertSignerOptions > qr signer lists every conflicting flag
(pass) assertSignerOptions > qr from env is also guarded
(pass) assertSignerOptions > qr signer rejects a keystore secret supplied via env

::endgroup::

::group::tests/unit/content/contentJson.test.ts:
(pass) content view --help shows --json option [3.00ms]
(pass) content set --help shows --json option [1.00ms]
(pass) content set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

::group::tests/unit/content/contentHelp.test.ts:
result:  {
  exitCode: 0,
  standardOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>            dotNS environment: paseo-v2, previewnet or\n                                 devnet (env: DOTNS_ENV)\n  --network <environment>        Alias for --env\n  --rpc <wsUrl>                  WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>         Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --account <name>               Keystore account name (default: keystore\n                                 default)\n  --password <pw>                Keystore password (env:\n                                 DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>        BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>            Substrate key URI (env: DOTNS_KEY_URI)\n  --signer <kind>                Signer: keystore (default) or qr [experimental]\n                                 (env: DOTNS_SIGNER) (default: \"keystore\")\n  --qr-app-id <id>               App id for QR pairing (env: DOTNS_QR_APP_ID)\n  --qr-people-rpc <stageOrUrls>  QR pairing relay: paseo|preview|stable or wss\n                                 URLs (env: DOTNS_QR_PEOPLE_RPC)\n  --qr-fresh                     Force a fresh QR pairing, ignoring any cached\n                                 session\n  --allow-dev-account            Sign with the shared public dev account when no\n                                 auth is configured (env:\n                                 DOTNS_ALLOW_DEV_ACCOUNT)\n  -h, --help                     display help for command\n\nCommands:\n  view [options] <name>          View domain content hash\n  set [options] <name> <cid>     Set domain content hash (IPFS CID)\n  help [command]                 display help for command\n",
  standardError: "",
  combinedOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>            dotNS environment: paseo-v2, previewnet or\n                                 devnet (env: DOTNS_ENV)\n  --network <environment>        Alias for --env\n  --rpc <wsUrl>                  WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>         Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --account <name>               Keystore account name (default: keystore\n                                 default)\n  --password <pw>                Keystore password (env:\n                                 DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>        BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>            Substrate key URI (env: DOTNS_KEY_URI)\n  --signer <kind>                Signer: keystore (default) or qr [experimental]\n                                 (env: DOTNS_SIGNER) (default: \"keystore\")\n  --qr-app-id <id>               App id for QR pairing (env: DOTNS_QR_APP_ID)\n  --qr-people-rpc <stageOrUrls>  QR pairing relay: paseo|preview|stable or wss\n                                 URLs (env: DOTNS_QR_PEOPLE_RPC)\n  --qr-fresh                     Force a fresh QR pairing, ignoring any cached\n                                 session\n  --allow-dev-account            Sign with the shared public dev account when no\n                                 auth is configured (env:\n                                 DOTNS_ALLOW_DEV_ACCOUNT)\n  -h, --help                     display help for command\n\nCommands:\n  view [options] <name>          View domain content hash\n  set [options] <name> <cid>     Set domain content hash (IPFS CID)\n  help [command]                 display help for command\n",
}
(pass) content --help lists subcommands and auth options [3.00ms]
(pass) content view --help shows name argument and options [1.00ms]
(pass) content set --help shows name and cid arguments [2.00ms]

::endgroup::

::group::tests/unit/bulletin/bulletinAuthorizer.test.ts:
(pass) bulletin authorizer default > defaults to //Eve, the seeded AllowedAuthorizers account
(pass) bulletin authorizer default > is distinct from the sudo key, which stays //Alice
(pass) warnIfDevKeyOnTestnet > warns when the default authorizer is used against previewnet
(pass) warnIfDevKeyOnTestnet > stays silent on paseo-v2 even with the default authorizer
(pass) warnIfDevKeyOnTestnet > stays silent when an explicit signer overrides the default
(pass) getPreviewUrl > returns an https preview link on the environment that has a web app
(pass) getPreviewUrl > returns null (never throws) on an environment with no web app

::endgroup::

::group::tests/unit/bulletin/bulletinCliHelp.test.ts:
(pass) root help lists bulletin command [2.00ms]
(pass) bulletin help shows commands and description [1.00ms]
(pass) bulletin upload help shows all options [2.00ms]
(pass) bulletin upload help shows default values [1.00ms]
(pass) bulletin authorize help shows all options [1.00ms]
(pass) bulletin authorize help shows default values [2.00ms]
(pass) bulletin history help shows options [1.00ms]
(pass) bulletin history:remove help shows usage [1.00ms]
(pass) bulletin history:clear help shows description [1.00ms]
(pass) bulletin help command shows bulletin help [2.00ms]
(pass) bulletin help upload shows upload help [1.00ms]
(pass) bulletin help authorize shows authorize help [1.00ms]
(pass) bulletin status help shows all options [1.00ms]
(pass) bulletin help status shows status help [2.00ms]
(pass) bulletin list alias works [1.00ms]
(pass) bulletin verify help shows usage [1.00ms]
(pass) bulletin help verify shows verify help [1.00ms]

::endgroup::

::group::tests/unit/bulletin/uploadManifest.test.ts:
(pass) upload manifest resume behavior > returns stale manifest when fingerprint does not match [1.00ms]
(pass) upload manifest resume behavior > deduplicates completed blocks by index

::endgroup::

::group::tests/unit/bulletin/uploadProfiling.test.ts:
(pass) upload profiler > writes schema-complete profile report with peak aggregation [21.00ms]
(pass) upload profiler > default profile path is deterministic for a given fingerprint

::endgroup::

::group::tests/unit/text/textHelp.test.ts:
(pass) text --help lists subcommands and auth options [2.00ms]
(pass) text view --help shows name and key arguments [1.00ms]
(pass) text set --help shows name, key, and value arguments [1.00ms]

::endgroup::

::group::tests/unit/text/textJson.test.ts:
(pass) text view --help shows --json option [1.00ms]
(pass) text set --help shows --json option [1.00ms]
(pass) text set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

 395 pass
 0 fail
 1027 expect() calls
Ran 395 tests across 45 files. [3.82s]

@re-gius re-gius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@re-gius
re-gius merged commit 15b19f2 into main Oct 14, 2026
21 checks passed
@re-gius
re-gius deleted the fix/dev-account-fail-closed branch October 14, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: --json swallows the shared-dev-account warning, and a typo'd env var silently signs with the public account

2 participants