Skip to content

fix(cli): derive the storage-deposit floor and token symbol from the chain - #319

Merged
re-gius merged 3 commits into
mainfrom
fix/storage-deposit-floor-decimals
Sep 25, 2026
Merged

re-gius merged 3 commits into
mainfrom
fix/storage-deposit-floor-decimals

Conversation

@re-gius

@re-gius re-gius commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Description

The storage deposit floor on every write was a hardcoded 2_000_000_000_000n planck: 200 tokens at 10 decimals, 100× its documented "2 PAS". It won on essentially every call, so the limit never came from the dry run. The floor is now two whole tokens of the connected chain, and the CLI reads the chain's decimals and symbol for every amount it caps or displays.

  • Deposit limit: computeStorageDepositLimit keeps the rule (dry run + 20%, floored at two tokens) with the floor at 2 × 10^decimals of the connected chain.
  • One source of token info: ReviveClientWrapper holds nativeTokenDecimals and nativeTokenSymbol; createDotnsContext reads both from it. Every Revive.call path passes chain metadata, including bulletin --cache, which reads it from Asset Hub.
  • Symbol: CLI amount lines (register, escrow, bulletin) print the chain's symbol. No PAS literal remains in packages/cli/src.
  • Parsing: getChainTokenInfo rejects unusable tokenDecimals ("", null and true used to become 0 or 1 decimals, a 2 or 20 planck floor) and warns when it falls back to the defaults.

Why DOT / 10 as defaults: Polkadot mainnet is the production target, so the fallbacks are the Polkadot Asset Hub values. They only apply when a chain reports no token properties; Polkadot AH (DOT/10), Paseo AH and previewnet AH (PAS/10) all report their own. CLI output on testnets still shows PAS. Only SDK callers who build new ReviveClientWrapper(client) without token info now see DOT labels; the deposit floor is unchanged.

Type

  • Bug fix
  • Feature
  • Breaking change
  • Documentation
  • Chore

Package

  • @parity/dotns-cli
  • Root/monorepo
  • Documentation

Related Issues

paritytech/dotns#226

Fixes

Closes paritytech/dotns#226

Checklist

Code

  • Follows project style
  • bun run lint passes
  • bun run format passes
  • bun run typecheck passes

Documentation

  • README updated if needed
  • Types updated if needed

Breaking Changes

  • No breaking changes
  • Breaking changes documented below

Breaking changes:

  • CreateDotnsContextOptions.nativeTokenDecimals is removed, since a second copy on the context could disagree with the wrapper. Pass token info to the wrapper instead: new ReviveClientWrapper(client, await getChainTokenInfo(rawClient)).
  • The default token symbol is DOT (was PAS). This only affects wrappers built without token info.

Testing

How to test:

  1. cd packages/cli && bun run test:unit: 367 tests pass, including the new tests/unit/client/storageDepositLimit.test.ts and tests/unit/client/chainTokenInfo.test.ts.
  2. Run any write against Paseo (e.g. dotns register domain ...): the configuration block shows Token: PAS (10 decimals), amounts are labelled PAS, and the call's storage_deposit_limit is at least 20_000_000_000 planck (two PAS).

Notes

  • account map builds its wrapper without token info. That is safe: map_account sets no storage deposit limit.
  • The UI's hardcoded PAS literals are left for a separate change.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

CI Summary

Check Result
Lint Passed
Lint (UI) Passed
Format Passed
Typecheck Passed
Typecheck (UI) Passed
Build Passed
Build (UI) Passed
Release Passed
Deploy UI Passed
Deploy Example Passed
Benchmark UI Failed
PR Title Passed
Labels Passed
Test Passed - 367 passed, 0 failed

Release - Passed

Test this PR

Download artifact (GitHub CLI required):

gh run download 36156873432 -n cli-release-0.0.0-pr.319 -R paritytech/dotns-sdk

Install globally:

npm install -g ./parity-dotns-cli-0.0.0-pr.319.tgz

Verify:

dotns --help
Deploy UI — Passed
Stage Status
✓ Build Build succeeded
✓ Deploy Deployed
Property Value
Domain pr319.dotns.dot
CID bafybeidnxyqyokal6qq6bn3ladypa4kwfoly4dmgmtef5ch5l4v6hmkppi
URL (dot.li) https://pr319.dotns.dot.li
URL (paseo.li) https://pr319.dotns.paseo.li
URL (direct) https://pr319.dotns.dot

View run

Deploy Example — Passed
Stage Status
✓ Site validation Site validated
✓ Deploy Deployed (cached)
Property Value
Domain pr319.dotns-example-site.dot
CID bafybeicx555prsudvmqsdrap7keoilryrudwycdx3ody2rejwqwjwp52u4 (cached)
URL (dot.li) https://pr319.dotns-example-site.dot.li
URL (paseo.li) https://pr319.dotns-example-site.paseo.li
URL (direct) https://pr319.dotns-example-site.dot
Duration 44s

View run

Benchmark UI - Failed (0s)
Property Value
Duration 0s
Domain n/a
CID n/a
Workflow view
Labels

pkg: cli, type: docs, type: test, pkg: ui

Test - Passed

367 passed, 0 failed across 367 tests.

View run

$ bun test tests/unit/
bun test v1.2.6 (8ebd5d53)

::group::tests/unit/store/storeHelp.test.ts:
(pass) store --help lists subcommands [18.00ms]
(pass) store claim --help shows description and auth options [6.00ms]
(pass) store info --help shows auth options [5.00ms]
(pass) store list --help shows options [3.00ms]
(pass) store get --help shows key argument [2.00ms]
(pass) store set --help shows key and value arguments with auth [3.00ms]
(pass) store delete --help shows key argument with auth [3.00ms]

::endgroup::

::group::tests/unit/inspect/prechecks.test.ts:
(pass) releaseName refuses before the approve > a name that is not registered [3.00ms]
(pass) releaseName refuses before the approve > a subname or lite name, which has no registrar token [1.00ms]
(pass) releaseName refuses before the approve > a soulbound personhood name [1.00ms]
(pass) releaseName refuses before the approve > a failed soulbound read, rather than treating it as not soulbound [1.00ms]
(pass) releaseName refuses before the approve > a name with no escrow position [2.00ms]
(pass) releaseName refuses before the approve > a name already released, saying until when the holder may redeem [1.00ms]
(pass) releaseName refuses before the approve > a name owned by another account [1.00ms]
(pass) releaseName refuses before the approve > otherwise approves the escrow and then releases
(pass) transferName refuses before the write > a subname or lite name, which has no registrar token [1.00ms]
(pass) transferName refuses before the write > a soulbound personhood name
(pass) transferName refuses before the write > a name owned by another account [1.00ms]
(pass) transferName refuses before the write > otherwise submits the transfer
(pass) ensureDomainNotRegistered > explains a name inside its redeem window and when registration opens [1.00ms]
(pass) ensureDomainNotRegistered > does not mention a redeem window for a held, unreleased name

::endgroup::

::group::tests/unit/utils/validation.test.ts:
(pass) normaliseLabel > lowercases, trims, and strips a single trailing .dot [1.00ms]
(pass) normaliseLabel > strips the given TLD suffix rather than assuming .dot
(pass) isSecondLevelDotName > distinguishes a second-level name from a subdomain under the given TLD
(pass) isCanonicalLabel > accepts lowercase letters, digits and internal hyphens
(pass) isCanonicalLabel > rejects dots, uppercase, spaces and other characters
(pass) isCanonicalLabel > rejects leading or trailing hyphens, empty and overlong labels
(pass) isSecondLevelDotName > accepts a single label, with or without the .dot suffix
(pass) isSecondLevelDotName > rejects subdomains
(pass) validateCanonicalLabel > throws for a name containing a dot, naming the role
(pass) validateCanonicalLabel > does not throw for a canonical label
(pass) validateDomainLabel digit-suffix rule > accepts labels with no trailing digits
(pass) validateDomainLabel digit-suffix rule > accepts labels with exactly two trailing digits
(pass) validateDomainLabel digit-suffix rule > accepts labels with any trailing digit count
(pass) validateDomainLabel digit-suffix rule > rejects labels shorter than three characters
(pass) validateDomainLabel digit-suffix rule > rejects labels with uppercase characters
(pass) validateDomainLabel digit-suffix rule > rejects labels with leading or trailing hyphen
(pass) validateGovernanceLabel stem-length rule > accepts stems of five characters or fewer
(pass) validateGovernanceLabel stem-length rule > rejects stems longer than five characters [1.00ms]
(pass) validateGovernanceLabel stem-length rule > measures an ordinary label whole, digits included
(pass) validateGovernanceLabel stem-length rule > does not apply the PopRules digit-suffix rule
(pass) validateGovernanceLabel measures the base as v0.6.0 does > accepts any digit count while the whole label stays within the reserved band
(pass) validateGovernanceLabel measures the base as v0.6.0 does > rejects once the label as written leaves the reserved band
(pass) validateGovernanceLabel measures the base as v0.6.0 does > the NORMAL path accepts any digit count too
(pass) validateGovernanceLabel canonical-label rules > rejects uppercase characters
(pass) validateGovernanceLabel canonical-label rules > rejects labels containing a dot
(pass) validateGovernanceLabel canonical-label rules > rejects leading or trailing hyphen
(pass) validateGovernanceLabel canonical-label rules > rejects labels shorter than three characters
(pass) isPersonLabel > accepts a letters-only name
(pass) isPersonLabel > rejects digits, hyphens, uppercase and the empty string
(pass) isLitePersonLabel > accepts a letters-only stem, one separator and exactly two digits [1.00ms]
(pass) isLitePersonLabel > rejects a stem the gateway could not have issued
(pass) isLitePersonLabel > rejects any other digit count or a missing separator
(pass) baseLabelOf > drops the separator and allocated digits from a lite label
(pass) baseLabelOf > measures an ordinary label whole
(pass) isSecondLevelDotName with a lite name > treats a lite name as one name, not a subdomain
(pass) isSecondLevelDotName with a lite name > still treats a real subname as a subdomain
(pass) lite names on the registration path > validateDomainLabel refuses a lite name with the gateway reason
(pass) lite names on the registration path > a shape the gateway cannot issue still gets the charset error
(pass) validateExistingNameLabel > accepts a lite name
(pass) validateExistingNameLabel > accepts an ordinary label
(pass) validateExistingNameLabel > still rejects a subname and other malformed input

::endgroup::

::group::tests/unit/utils/contractInteractions.test.ts:
(pass) deriveDomainNode > matches namehashUnder(tldNode, labelhash) [1.00ms]
(pass) deriveDomainNode > different TLDs yield different nodes for the same label
(pass) deriveDomainNode > folds a subname per label from the TLD node
(pass) deriveDomainNode > agrees with viem's namehash of the fully qualified name [2.00ms]
(pass) deriveDomainNode > folds a lite personhood name beneath its numeric container (v0.7.0)
(pass) deriveDomainNode > deriveLegacyLiteNode hashes the whole lite label flat (pre-v0.7.0) [1.00ms]
(pass) deriveDomainTokenId > is uint256(node)
(pass) deriveDomainTokenId > known vector: getsome under .dot
(pass) isRevertFlag matches the EVM revert bit > flags=0n → false [1.00ms]
(pass) isRevertFlag matches the EVM revert bit > flags=1n → true
(pass) isRevertFlag matches the EVM revert bit > flags=2n → false
(pass) isRevertFlag matches the EVM revert bit > flags=3n → true
(pass) buildRevertError > empty data names both the unmapped-origin and stale-ABI causes
(pass) buildRevertError > known ABI selector decodes to the named error [2.00ms]
(pass) buildRevertError > unknown selector falls back to raw hex [2.00ms]
(pass) decodeContractRevertError > empty data includes operation context
(pass) decodeContractRevertError > non-empty data decodes against the ABI [1.00ms]

::endgroup::

::group::tests/unit/account/accountHelp.test.ts:
(pass) account --help lists subcommands including is-mapped and grant [5.00ms]
(pass) account is-mapped --help shows address argument and --json [3.00ms]
(pass) account grant --help shows label argument and --json [2.00ms]

::endgroup::

::group::tests/unit/delegate/delegateHelp.test.ts:
(pass) delegate --help lists set, revoke, status, records and auth options [4.00ms]
(pass) delegate records --help shows operator argument and --revoke [3.00ms]
(pass) delegate records-status --help shows operator argument and --json [4.00ms]
(pass) delegate set --help shows name and delegate arguments [3.00ms]
(pass) delegate revoke --help shows name argument [3.00ms]
(pass) delegate status --help shows name argument and --json [4.00ms]

::endgroup::

::group::tests/unit/auth/resolveAuthSourceReadOnly.test.ts:
(pass) resolveAuthSourceReadOnly honours environment variables > $label [1.00ms]
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label

::endgroup::

::group::tests/unit/auth/authRevert.test.ts:
(pass) auth set rejects account name with forward slash [4.00ms]
(pass) auth set rejects account name with backslash [3.00ms]
(pass) auth set rejects account name that is just a dot [2.00ms]
(pass) auth set rejects account name that is double dots [2.00ms]
(pass) auth set rejects account name starting with dot [4.00ms]
(pass) auth set rejects account name ending with dot [3.00ms]
(pass) auth set rejects account name with special characters [14.00ms]
(pass) auth set rejects account name that is too long [3.00ms]
(pass) auth use rejects non-existent account [82.00ms]
(pass) auth remove rejects non-existent account [64.00ms]

::endgroup::

::group::tests/unit/auth/authHelp.test.ts:
(pass) root help lists auth command [3.00ms]
(pass) auth help shows options and subcommands [2.00ms]
(pass) auth set help shows all options [2.00ms]
(pass) auth list help shows options [1.00ms]
(pass) auth use help shows options [2.00ms]
(pass) auth remove help shows options [2.00ms]
(pass) auth clear help shows options [2.00ms]
(pass) auth parses keystore-path option [2.00ms]
(pass) auth parses password option [2.00ms]
(pass) auth set parses account option [2.00ms]
(pass) auth set parses mnemonic option [2.00ms]
(pass) auth set parses key-uri option [3.00ms]
(pass) auth help command shows help [2.00ms]
(pass) auth help set shows set command help [2.00ms]
(pass) auth help list shows list command help [2.00ms]
(pass) auth help use shows use command help [2.00ms]
(pass) auth help remove shows remove command help [2.00ms]
(pass) auth help clear shows clear command help [2.00ms]

::endgroup::

::group::tests/unit/auth/auth.test.ts:
(pass) auth set creates keystore and stores multiple accounts [264.00ms]
(pass) auth set accepts account names with special characters [407.00ms]
(pass) auth list reports missing keystore [5.00ms]
(pass) auth list shows all accounts and auth types [265.00ms]
(pass) auth use switches default account [397.00ms]
(pass) auth remove last account clears default [80.00ms]
(pass) auth remove preserves remaining accounts and reassigns default [201.00ms]
(pass) auth clear deletes all accounts [66.00ms]
(pass) resolveAuthSource prefers selected keystore account over ambient env mnemonic [199.00ms]
(pass) resolveAuthSource resolves from env mnemonic when only the default keystore path is given
(pass) resolveAuthSource prefers selected keystore account over ambient env key URI [139.00ms]
(pass) auth set rejects weak password supplied by flag for new keystore [5.00ms]
(pass) auth set rejects weak password supplied by env for new keystore [3.00ms]
(pass) resolveAuthSource default branch carries the dev credential for the retry cache [1.00ms]

::endgroup::

::group::tests/unit/primary/primaryHelp.test.ts:
(pass) primary --help lists set, status and auth options [3.00ms]
(pass) primary set --help shows name argument and --json [2.00ms]
(pass) primary status --help shows optional address argument and --json [1.00ms]

::endgroup::

::group::tests/unit/client/storageDepositLimit.test.ts:
(pass) computeStorageDepositLimit > floors at two whole tokens for 10 decimals
(pass) computeStorageDepositLimit > floors at two whole tokens for 12 decimals
(pass) computeStorageDepositLimit > keeps the floor when the buffered estimate is below it
(pass) computeStorageDepositLimit > uses the estimate plus 20% once it exceeds the floor
(pass) ReviveClientWrapper token info > defaults to DEFAULT_NATIVE_TOKEN_DECIMALS and DEFAULT_NATIVE_TOKEN_SYMBOL
(pass) ReviveClientWrapper token info > rejects non-integer and negative decimals [1.00ms]
(pass) ReviveClientWrapper token info > rejects an empty symbol
(pass) ReviveClientWrapper token info > createDotnsContext reads token info from the wrapper [2.00ms]
(pass) submitTransaction storage_deposit_limit > applies the connected chain's two-token floor [1.00ms]
(pass) submitTransaction storage_deposit_limit > derives the limit from the dry run when it exceeds the floor

::endgroup::

::group::tests/unit/client/chainTokenInfo.test.ts:
(pass) getChainTokenInfo > reads scalar properties
(pass) getChainTokenInfo > reads the first entry of array properties
(pass) getChainTokenInfo > accepts decimals encoded as a digit string
(pass) getChainTokenInfo > falls back to the defaults with a warning when properties are missing
(pass) getChainTokenInfo > falls back to the default decimals for ""
(pass) getChainTokenInfo > falls back to the default decimals for null
(pass) getChainTokenInfo > falls back to the default decimals for true
(pass) getChainTokenInfo > falls back to the default decimals for -1
(pass) getChainTokenInfo > falls back to the default decimals for 1.5
(pass) getChainTokenInfo > falls back to the default decimals for "1.5"
(pass) getChainTokenInfo > falls back to the default decimals for []
(pass) getChainTokenInfo > falls back to the default symbol for an empty string

::endgroup::

::group::tests/unit/register/subnodePersist.test.ts:
(pass) registerSubnode encodes the persist flag > persists into the owner's store by default [1.00ms]
(pass) registerSubnode encodes the persist flag > skips store indexing when persist is disabled [1.00ms]

::endgroup::

::group::tests/unit/register/registrationManifest.test.ts:
(pass) registration manifest persistence > saves a record and reads it back by label [58.00ms]
(pass) registration manifest persistence > stores the sealed pricing fields losslessly as decimal strings [60.00ms]
(pass) registration manifest persistence > encrypts the secret at rest (never stored in plaintext) [75.00ms]
(pass) registration manifest persistence > decrypts the secret with the correct credential [116.00ms]
(pass) registration manifest persistence > rejects decryption with the wrong credential [132.00ms]
(pass) registration manifest persistence > lists records for the env + caller, newest commit first [114.00ms]
(pass) registration manifest persistence > isolates records by env and caller [131.00ms]
(pass) registration manifest persistence > deletes a record [58.00ms]
(pass) registration manifest persistence > returns empty when nothing is cached
(pass) registration manifest persistence > clear record selection scopes to a requested label [117.00ms]
(pass) registration manifest persistence > clear record selection errors when a requested label is missing [72.00ms]
(pass) resolveManifestCredential > prefers password, then mnemonic, then key URI
(pass) resolveManifestCredential > returns null when no credential is available
(pass) resolveManifestCredential > uses env mnemonic and key URI for registration cache encryption
(pass) TLD ingested from chain > resolveTldInfo reads the deployment TLD rather than assuming .dot
(pass) TLD ingested from chain > retries a transient read failure before resolving [302.00ms]
(pass) TLD ingested from chain > the immutable TLD is cached across calls
(pass) TLD ingested from chain > does not share the cache between clients that share a controller address
(pass) TLD ingested from chain > computeDomainTokenId derives the id under the chain TLD
(pass) TLD ingested from chain > formatDomainName uses the deployment TLD suffix
(pass) ensureDomainNotRegistered enforces the controller predicate > passes when available(label) is true, checking available not ownerOf
(pass) ensureDomainNotRegistered enforces the controller predicate > throws with the real TLD suffix when available(label) is false [1.00ms]

::endgroup::

::group::tests/unit/register/registerOwnerConflicts.test.ts:
(pass) register domain rejects --owner with --transfer [4.00ms]
(pass) register domain rejects --owner with --reverse [2.00ms]
(pass) register domain rejects --owner with --governance [3.00ms]

::endgroup::

::group::tests/unit/register/registerJson.test.ts:
(pass) register domain --help shows --json option [2.00ms]
(pass) register subname --help shows --json option [2.00ms]
(pass) register domain --json emits JSON error when --transfer without --to [2.00ms]

::endgroup::

::group::tests/unit/register/registerHelp.test.ts:
(pass) root help lists register command [3.00ms]
(pass) register help shows subcommands [2.00ms]
(pass) register domain help shows options [2.00ms]
(pass) register subname help shows options [2.00ms]
(pass) register domain parses reverse flag [3.00ms]
(pass) register domain parses governance flag [2.00ms]
(pass) register domain parses owner option [3.00ms]
(pass) register domain parses transfer with destination [2.00ms]
(pass) register domain parses account option [3.00ms]
(pass) register domain parses keystore-path option [2.00ms]
(pass) register domain parses password option [2.00ms]
(pass) register domain parses mnemonic option [3.00ms]
(pass) register domain parses key-uri option [2.00ms]
(pass) register domain parses commitment-buffer option [2.00ms]
(pass) register domain parses commitment-buffer alias --cb [2.00ms]
(pass) register subname parses name and parent [3.00ms]
(pass) register subname parses owner option [2.00ms]
(pass) getCommitmentBufferSeconds defaults to 6 when env is not set
(pass) getCommitmentBufferSeconds reads from DOTNS_COMMITMENT_BUFFER env variable
(pass) COMMITMENT_POLL_INTERVAL_MS is 2000
(pass) COMMITMENT_POLL_TIMEOUT_MS is 30000

::endgroup::

::group::tests/unit/pop/setPopHelp.test.ts:
(pass) root help lists pop command [3.00ms]
(pass) pop help shows commands and description [1.00ms]
(pass) pop help shows auth options [2.00ms]
(pass) pop info help shows description [2.00ms]
(pass) pop status help shows description [2.00ms]
(pass) pop info help shows auth options [1.00ms]
(pass) pop info parses auth options at pop level [1.00ms]
(pass) pop info parses auth options at info level [2.00ms]
(pass) pop help command shows pop help [1.00ms]
(pass) pop help status shows info help [2.00ms]
(pass) pop help info shows info help [1.00ms]

::endgroup::

::group::tests/unit/pop/popJson.test.ts:
(pass) pop info --help shows --json option [3.00ms]
(pass) pop status --help shows --json option [1.00ms]

::endgroup::

::group::tests/unit/lookup/lookupHelp.test.ts:
(pass) lookup --help lists subcommands and auth options [2.00ms]
(pass) lookup name --help shows label argument and options [1.00ms]
(pass) lookup owner-of --help shows label argument and options [2.00ms]
(pass) lookup transfer --help shows label argument and destination option [3.00ms]
(pass) lookup transfer parses destination at transfer level [3.00ms]
(pass) lookup transfer parses auth options at lookup level [3.00ms]

::endgroup::

::group::tests/unit/lookup/lookupNormalisation.test.ts:
(pass) lookup normalises fully-qualified names > performDomainLookup derives the same node for `alice` and `alice.paseo` [1.00ms]
(pass) lookup normalises fully-qualified names > performOwnerOfLookup derives the same node for `alice` and `alice.paseo`
(pass) lookup normalises fully-qualified names > a name under a different suffix is not stripped [1.00ms]
(pass) lite names resolve on both node schemes > a v0.7.0 lite name resolves at its folded subnode [1.00ms]
(pass) lite names resolve on both node schemes > a pre-v0.7.0 lite name falls back to its flat node [1.00ms]
(pass) lite names resolve on both node schemes > an unregistered lite name reports the legacy node and no record
(pass) lookup folds subnames per label > performDomainLookup queries the EIP-137 node of `blog.alice` [1.00ms]
(pass) lookup folds subnames per label > `blog.alice` and `blog.alice.paseo` resolve to the same node
(pass) lookup folds subnames per label > performOwnerOfLookup reads the registry owner, so a subname reports its holder [1.00ms]
(pass) lookup folds subnames per label > performOwnerOfLookup reports an unregistered name as such

::endgroup::

::group::tests/unit/escrow/escrowHelp.test.ts:
(pass) root help lists escrow command [4.00ms]
(pass) escrow help shows the subcommand description and subcommands [3.00ms]
(pass) escrow balance help describes the claimable pull-payment balance [3.00ms]
(pass) escrow positions help describes the list and total [2.00ms]
(pass) escrow status help describes the read-only position lookup [2.00ms]
(pass) escrow release help describes the approve-and-release sequence [1.00ms]
(pass) escrow withdraw help describes the post-cooldown step [2.00ms]
(pass) escrow claim-withdrawal help describes the overpayment ledger [2.00ms]
(pass) escrow refunds help lists list/claim/claim-batch [1.00ms]
(pass) escrow refunds list help exposes pagination options [2.00ms]
(pass) escrow refunds claim help requires an entry id positional [1.00ms]
(pass) escrow refunds claim-batch help accepts variadic ids [2.00ms]

::endgroup::

::group::tests/unit/escrow/escrowFormatting.test.ts:
(pass) formatRefundEntryLine > marks entries past their cooldown as claimable [1.00ms]
(pass) formatRefundEntryLine > marks entries inside their cooldown window with remaining seconds
(pass) formatRefundEntryLine > renders the amount in the chain's native token symbol [1.00ms]
(pass) formatRefundEntryLine > truncates large tokenIds for terminal display
(pass) totalEscrowAmount > is zero for no positions
(pass) totalEscrowAmount > sums position amounts
(pass) isRefundableDeposit > is true only when the position holds an amount
(pass) cooldownRemainingSeconds > returns the seconds left, clamped to zero once elapsed
(pass) formatCooldown > formats seconds and minutes
(pass) formatPositionStatus > held when not released
(pass) formatPositionStatus > embeds the cooldown countdown while released and waiting
(pass) formatPositionStatus > claimable once the cooldown elapses
(pass) formatPositionStatus > claimed after withdrawal
(pass) formatPositionsTable > returns no lines for an empty set
(pass) formatPositionsTable > renders a header plus one aligned row per position with the cooldown
(pass) pendingRefunds multi-output decode > decodes to a [ids, entries] tuple [2.00ms]
(pass) pendingRefunds multi-output decode > decodes an empty ledger to a pair of empty arrays

::endgroup::

::group::tests/unit/cli/paseoCreate3Addresses.test.ts:
(pass) paseo-v2 uses the canonical fresh-deploy address book
(pass) previewnet shares the whole paseo-v2 book
(pass) devnet keeps its own distinct deployment

::endgroup::

::group::tests/unit/cli/bulletinRpc.test.ts:
(pass) paseo-v2 default resolves to the existing bulletin RPC
(pass) explicit argument wins over env var and active env [1.00ms]
(pass) env var wins over active env config when no explicit argument
(pass) falls back to active env's bulletin RPC
(pass) throws when nothing is configured (synthetic case)
(pass) bulletin cache Asset Hub RPC uses merged CLI rpc before DOTNS_RPC
(pass) bulletin cache Asset Hub RPC uses selected environment when no rpc override exists
(pass) bulletin cache rejects custom Bulletin env override without matching target
(pass) bulletin cache accepts custom Bulletin override with explicit environment
(pass) bulletin cache custom Bulletin with DOTNS_ENV ignores stale DOTNS_RPC
(pass) bulletin cache accepts custom Bulletin override with explicit Asset Hub RPC

::endgroup::

::group::tests/unit/cli/environment.test.ts:
(pass) defaults to paseo-v2
(pass) accepts friendly paseo-v2 aliases
(pass) DOTNS_ENV selects rpc and contract set
(pass) --env takes precedence over DOTNS_ENV while --rpc only overrides endpoint
(pass) printCommandHeader emits one contextual line with version, action, target and network

::endgroup::

::group::tests/unit/cli/authOptions.test.ts:
(pass) getAuthOptions resolves a global --env given before a two-level-nested command
(pass) getAuthOptions lets a command-level --env override the global one
(pass) getAuthOptions resolves the --network alias from the program root [1.00ms]

::endgroup::

::group::tests/unit/cli/qrSigner.test.ts:
⚠ The QR mobile-wallet signer is experimental and still in development; expect rough edges.
(pass) createQrSigner > throws a clear error when no global WebSocket is available [1.00ms]
⚠ The QR mobile-wallet signer is experimental and still in development; expect rough edges.
Approve the signing allowance on your phone to continue.
(pass) createQrSigner > returns the SS58 origin derived from the paired signer's public key [1.00ms]

::endgroup::

::group::tests/unit/cli/transfer.test.ts:
(pass) resolveTransferRecipient > returns a raw EVM address in checksummed form without touching the chain [1.00ms]
(pass) resolveTransferRecipient > rejects input that is neither an EVM address, SS58 address, nor domain name

::endgroup::

::group::tests/unit/cli/assertExpectedChain.test.ts:
(pass) assertExpectedChain > passes when the chain reports the environment's genesis
(pass) assertExpectedChain > fails naming both chains on a mismatch
(pass) assertExpectedChain > hash comparison is case-insensitive
(pass) assertExpectedChain > a null pinned hash skips the check
(pass) assertExpectedChain > a bulletin mismatch points at the bulletin knobs [1.00ms]
(pass) assertExpectedChain > the escape hatch bypasses the check
(pass) assertExpectedChain > a known chain is named in the error, not just hashed
(pass) assertExpectedChain > the bulletin connection is checked against the bulletin genesis
(pass) assertExpectedChain > the caller can inject the environment

::endgroup::

::group::tests/unit/cli/dotliViewUrls.test.ts:
(pass) paseo-v2 emits only its paseo.li gateway
(pass) devnet emits only its dev-dot.li gateway
(pass) previewnet emits no dot.li gateway [1.00ms]
(pass) passes the label through unchanged, so the TLD is never duplicated

::endgroup::

::group::tests/unit/cli/signerKind.test.ts:
(pass) resolveSignerKind > defaults to keystore
(pass) resolveSignerKind > reads DOTNS_SIGNER=qr
(pass) resolveSignerKind > an explicit flag overrides the env var
(pass) resolveSignerKind > an unknown value falls back to keystore
(pass) resolveQrAppId > defaults to the unified product id
(pass) resolveQrAppId > flag beats env beats default
(pass) resolveQrPeopleEndpoints > defaults to the paseo stage [1.00ms]
(pass) resolveQrPeopleEndpoints > resolves named stages
(pass) resolveQrPeopleEndpoints > treats a non-stage value as a comma-separated wss list
(pass) resolveQrPeopleEndpoints > rejects a non-wss URL
(pass) resolveQrPeopleEndpoints > rejects an empty/blank value
(pass) resolveQrPeopleEndpoints > rejects a wss URL with embedded credentials
(pass) resolveQrPeopleEndpoints > flag beats env beats default
(pass) assertSignerOptions > keystore signer allows local-account flags
(pass) assertSignerOptions > qr signer with no local flags is allowed
(pass) assertSignerOptions > qr signer rejects a local-account flag
(pass) assertSignerOptions > qr signer lists every conflicting flag
(pass) assertSignerOptions > qr from env is also guarded
(pass) assertSignerOptions > qr signer rejects a keystore secret supplied via env

::endgroup::

::group::tests/unit/content/contentJson.test.ts:
(pass) content view --help shows --json option [2.00ms]
(pass) content set --help shows --json option [1.00ms]
(pass) content set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

::group::tests/unit/content/contentHelp.test.ts:
result:  {
  exitCode: 0,
  standardOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>            DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>        Alias for --env\n  --rpc <wsUrl>                  WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>         Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --account <name>               Keystore account name (default: keystore\n                                 default)\n  --password <pw>                Keystore password (env:\n                                 DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>        BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>            Substrate key URI (env: DOTNS_KEY_URI)\n  --signer <kind>                Signer: keystore (default) or qr [experimental]\n                                 (env: DOTNS_SIGNER) (default: \"keystore\")\n  --qr-app-id <id>               App id for QR pairing (env: DOTNS_QR_APP_ID)\n  --qr-people-rpc <stageOrUrls>  QR pairing relay: paseo|preview|stable or wss\n                                 URLs (env: DOTNS_QR_PEOPLE_RPC)\n  --qr-fresh                     Force a fresh QR pairing, ignoring any cached\n                                 session\n  -h, --help                     display help for command\n\nCommands:\n  view [options] <name>          View domain content hash\n  set [options] <name> <cid>     Set domain content hash (IPFS CID)\n  help [command]                 display help for command\n",
  standardError: "",
  combinedOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>            DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>        Alias for --env\n  --rpc <wsUrl>                  WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>         Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --account <name>               Keystore account name (default: keystore\n                                 default)\n  --password <pw>                Keystore password (env:\n                                 DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>        BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>            Substrate key URI (env: DOTNS_KEY_URI)\n  --signer <kind>                Signer: keystore (default) or qr [experimental]\n                                 (env: DOTNS_SIGNER) (default: \"keystore\")\n  --qr-app-id <id>               App id for QR pairing (env: DOTNS_QR_APP_ID)\n  --qr-people-rpc <stageOrUrls>  QR pairing relay: paseo|preview|stable or wss\n                                 URLs (env: DOTNS_QR_PEOPLE_RPC)\n  --qr-fresh                     Force a fresh QR pairing, ignoring any cached\n                                 session\n  -h, --help                     display help for command\n\nCommands:\n  view [options] <name>          View domain content hash\n  set [options] <name> <cid>     Set domain content hash (IPFS CID)\n  help [command]                 display help for command\n",
}
(pass) content --help lists subcommands and auth options [3.00ms]
(pass) content view --help shows name argument and options [2.00ms]
(pass) content set --help shows name and cid arguments [1.00ms]

::endgroup::

::group::tests/unit/bulletin/bulletinAuthorizer.test.ts:
(pass) bulletin authorizer default > defaults to //Eve, the seeded AllowedAuthorizers account
(pass) bulletin authorizer default > is distinct from the sudo key, which stays //Alice
(pass) warnIfDevKeyOnTestnet > warns when the default authorizer is used against previewnet
(pass) warnIfDevKeyOnTestnet > stays silent on paseo-v2 even with the default authorizer
(pass) warnIfDevKeyOnTestnet > stays silent when an explicit signer overrides the default
(pass) getPreviewUrl > returns an https preview link on the environment that has a web app [1.00ms]
(pass) getPreviewUrl > returns null (never throws) on an environment with no web app

::endgroup::

::group::tests/unit/bulletin/bulletinCliHelp.test.ts:
(pass) root help lists bulletin command [2.00ms]
(pass) bulletin help shows commands and description [3.00ms]
(pass) bulletin upload help shows all options [2.00ms]
(pass) bulletin upload help shows default values [2.00ms]
(pass) bulletin authorize help shows all options [2.00ms]
(pass) bulletin authorize help shows default values [1.00ms]
(pass) bulletin history help shows options [2.00ms]
(pass) bulletin history:remove help shows usage [2.00ms]
(pass) bulletin history:clear help shows description [2.00ms]
(pass) bulletin help command shows bulletin help [2.00ms]
(pass) bulletin help upload shows upload help [2.00ms]
(pass) bulletin help authorize shows authorize help [2.00ms]
(pass) bulletin status help shows all options [1.00ms]
(pass) bulletin help status shows status help [2.00ms]
(pass) bulletin list alias works [1.00ms]
(pass) bulletin verify help shows usage [2.00ms]
(pass) bulletin help verify shows verify help [2.00ms]

::endgroup::

::group::tests/unit/bulletin/uploadManifest.test.ts:
(pass) upload manifest resume behavior > returns stale manifest when fingerprint does not match [2.00ms]
(pass) upload manifest resume behavior > deduplicates completed blocks by index [1.00ms]

::endgroup::

::group::tests/unit/bulletin/uploadProfiling.test.ts:
(pass) upload profiler > writes schema-complete profile report with peak aggregation [24.00ms]
(pass) upload profiler > default profile path is deterministic for a given fingerprint

::endgroup::

::group::tests/unit/text/textHelp.test.ts:
(pass) text --help lists subcommands and auth options [2.00ms]
(pass) text view --help shows name and key arguments [3.00ms]
(pass) text set --help shows name, key, and value arguments [1.00ms]

::endgroup::

::group::tests/unit/text/textJson.test.ts:
(pass) text view --help shows --json option [1.00ms]
(pass) text set --help shows --json option [2.00ms]
(pass) text set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

 367 pass
 0 fail
 977 expect() calls
Ran 367 tests across 41 files. [4.52s]

@charlesHetterich

charlesHetterich commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

For the breaking change on nativeTokenDecimals, CreateDotnsContextOptions.nativeTokenDecimals was previously accessible from public package via @parity/dotns-cli/core. Currently the new helper meant to replace this getChainTokenInfo is not available through the public sdk surface area— so that function should be exported through core/index.ts.

NativeTokenInfo type should be exported as well.

Extra NIT: might be good to move getChainTokenInfo definition out of CLI layer so the export isn't depending on CLI layer modules

@GHkrishna GHkrishna left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the nit comment below, I feel in the cli readme we are still using:

const client = createClient(getWsProvider("wss://paseo-asset-hub-next-rpc.polkadot.io"));
const ctx = createDotnsContext({
  clientWrapper: new ReviveClientWrapper(client.getTypedApi(paseo)),
  origin, // your SS58 address
  signer, // your PolkadotSigner
  environment: "paseo-v2",
});

should we be updating it to the await getChainTokenInfo(rawClient) param too??

Comment thread packages/cli/src/cli/commands/bulletin.ts Outdated
@re-gius

re-gius commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

For the breaking change on nativeTokenDecimals, CreateDotnsContextOptions.nativeTokenDecimals was previously accessible from public package via @parity/dotns-cli/core. Currently the new helper meant to replace this getChainTokenInfo is not available through the public sdk surface area— so that function should be exported through core/index.ts.

NativeTokenInfo type should be exported as well.

Extra NIT: might be good to move getChainTokenInfo definition out of CLI layer so the export isn't depending on CLI layer modules

Done in 8cec89a . getChainTokenInfo and the NativeTokenInfo type are now exported from @parity/dotns-cli/core. I also moved getChainTokenInfo out of the CLI layer into client/polkadotClient.ts, next to ReviveClientWrapper

@re-gius

re-gius commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

Apart from the nit comment below, I feel in the cli readme we are still using:

const client = createClient(getWsProvider("wss://paseo-asset-hub-next-rpc.polkadot.io"));
const ctx = createDotnsContext({
  clientWrapper: new ReviveClientWrapper(client.getTypedApi(paseo)),
  origin, // your SS58 address
  signer, // your PolkadotSigner
  environment: "paseo-v2",
});

should we be updating it to the await getChainTokenInfo(rawClient) param too??

Yes, updated in 8cec89a
The README example and the SDK docs page now build the wrapper with await getChainTokenInfo(client), which is exported from @parity/dotns-cli/core.

@GHkrishna GHkrishna left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@re-gius
re-gius merged commit d4535ce into main Sep 25, 2026
21 checks passed
@re-gius
re-gius deleted the fix/storage-deposit-floor-decimals branch September 25, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The storage-deposit floor is a hardcoded testnet amount, 100× its documented value

3 participants