Repository navigation
Conversation
Signed-off-by: GHkrishna <krishna@parity.io>
Signed-off-by: GHkrishna <krishna@parity.io>
github-actions
Bot
requested review from
corey-hathaway,
filvecchiato and
sphamjoli
September 14, 2026 10:03
CI Summary
Release - PassedTest this PR Download artifact (GitHub CLI required): gh run download 34831164988 -n cli-release-0.0.0-pr.303 -R paritytech/dotns-sdkInstall globally: npm install -g ./parity-dotns-cli-0.0.0-pr.303.tgzVerify: dotns --helpDeploy Example — Passed
Labelspkg: cli Test - Passed322 passed, 0 failed across 322 tests. |
Author
|
Should be merged, after this PR: paritytech/dotns#302 (review) is merged |
re-gius
marked this pull request as draft
October 8, 2026 12:33
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DotNS is changing how governance-only actions get authorized. Before, contracts checked whether a call's origin was "Root" directly. Now there's a new DotnsRootGateway contract that Root talks to, and every governance action (like force-registering a reserved name) has to go through that gateway instead.
This PR updates the SDK to know about that gateway: it adds the gateway's ABI so the SDK can talk to it later, adds a small helper (resolveRootGateway) that looks up the gateway's address the same way the SDK already looks up other contract addresses, and updates a few comments and CLI messages that used to say "Root origin" so they now correctly describe "routed through the DotnsRootGateway."
Nothing in the SDK actually calls through the gateway yet. There's no governance-dispatch flow. This just gets the SDK's docs, messages, and lookup helper in sync with the new contract shape so a future dispatch feature doesn't have to re-derive any of this.
Type
Package
@parity/dotns-cliRelated Issues
Fixes
Stale references to "Root origin" gating in register.ts and accountChecks.ts that no longer match how the contracts actually authorize governance calls (they now go through DotnsRootGateway, not a raw Root-origin check).
Checklist
Code
bun run lintpassesbun run formatpassesbun run typecheckpassesDocumentation
Breaking Changes
Breaking changes:
Testing
How to test:
Notes
Checked against the finalized fix/root-origin-gates branch in the dotns contracts, the gateway's ABI, the "rootGateway" protocol-registry key, and the 16 gated entry points this comment references all match what's actually implemented there.