Skip to content

perf(manager): batch package lookup and add persistent operation logging #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parviz-sudo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(manager): batch package lookup and add persistent operation logging #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
import logging
import os

_log_path = os.path.expanduser("~/.local/share/parch-driver-manager/operations.log")
os.makedirs(os.path.dirname(_log_path), exist_ok=True)
logging.basicConfig(filename=_log_path, level=logging.INFO,
format='%(asctime)s %(levelname)s: %(message)s')

from typing import List, Callable, Optional
from system_prober import SystemProber
from backend import BackendRunner
Expand All @@ -13,30 +21,40 @@ def get_installed_packages(self) -> List[str]:
return []
return out.splitlines()

def get_installed_packages(self) -> List[str]:
code, out, err = SystemProber.run_command(["pacman", "-Qq"])
if code != 0:
return []
return out.splitlines()

def is_package_installed(self, pkg: str) -> bool:
code, _, _ = SystemProber.run_command(["pacman", "-Qq", pkg])
return code == 0

def install_profile(self, profile: DriverProfile, progress_cb: Optional[Callable[[str], None]] = None):
pkgs_to_install = [p for p in profile.packages if not self.is_package_installed(p)]
installed = self.get_installed_packages_set()
pkgs_to_install = [p for p in profile.packages if p not in installed]
if not pkgs_to_install:
if progress_cb: progress_cb("All packages in this profile are already installed.")
return

if progress_cb: progress_cb(f"Installing: {' '.join(pkgs_to_install)}")
logging.info(f"Installing packages: {pkgs_to_install}")
self.backend.run(["pacman", "-S", "--needed", "--noconfirm"] + pkgs_to_install, check=True)

if profile.post_install:
if progress_cb: progress_cb("Running post-install steps…")
profile.post_install(self.backend)

def remove_profile(self, profile: DriverProfile, progress_cb: Optional[Callable[[str], None]] = None):
pkgs_to_remove = [p for p in profile.packages if self.is_package_installed(p)]
installed = self.get_installed_packages_set()
pkgs_to_remove = [p for p in profile.packages if p in installed]
if not pkgs_to_remove:
if progress_cb: progress_cb("None of the packages in this profile are installed.")
return

if progress_cb: progress_cb(f"Removing: {' '.join(pkgs_to_remove)}")
logging.info(f"Removing packages: {pkgs_to_remove}")
self.backend.run(["pacman", "-Rns", "--noconfirm"] + pkgs_to_remove, check=True)

if profile.post_remove:
Expand Down