Repository navigation
build: select target platform for runtime image - #6460
Merged
Merged
Conversation
Declare TARGETPLATFORM before FROM so Podman 4.9.4 resolves the runtime base for each target instead of falling back to amd64. The previous ARM64 image contained an ARM64 Parca binary but an x86-64 shell. Check the ELF machine of BusyBox, Parca, and the health probe for both platforms before publishing development or release images. Amp-Thread-ID: https://ampcode.com/threads/T-517b18b9-24b8-42c5-a008-0543f6960b36 Co-authored-by: Amp <amp@ampcode.com>
|
✅ Meticulous spotted 0 visual differences across 14 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit |
Remove the bundled health-probe executable from runtime and development images. Kubernetes probes call Parca's existing gRPC health service. Keep the runtime platform fix without the additional Make target or publishing workflow checks. Amp-Thread-ID: https://ampcode.com/threads/T-517b18b9-24b8-42c5-a008-0543f6960b36 Co-authored-by: Amp <amp@ampcode.com>
metalmatze
approved these changes
Oct 30, 2026
metalmatze
left a comment
metalmatze
left a comment
Member
There was a problem hiding this comment.
Replace exec health probes with Kubernetes native gRPC probes
Finally the future is now.
Create the data directory in the build-platform stage and copy it into the runtime image with its original ownership. Multi-architecture builds then need no ARM emulation on the AMD64 publishing runner. Amp-Thread-ID: https://ampcode.com/threads/T-517b18b9-24b8-42c5-a008-0543f6960b36 Co-authored-by: Amp <amp@ampcode.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare
TARGETPLATFORMbeforeFROMso Podman 4.9.4 resolves the runtime base for each target instead of falling back to AMD64. The published ARM64 image contains an ARM64 Parca binary but an x86-64 BusyBox, causing/bin/shto fail withexec format erroron ARM nodes. Create/datain the build-platform stage and copy it with its original ownership so cross-architecture builds do not require emulation.Replace exec health probes with Kubernetes native gRPC probes against Parca's existing health service. Remove the health-probe executable from production and development images and its Renovate rule.
Verified AMD64 and ARM64 builds with the publishing workflow's Podman 4.9.4 and ARM emulation disabled. Shell and Parca execute on both, with ARM64 runtime checks under QEMU, and
nobodycan write/data. A native gRPC health request returnsSERVING; Jsonnet renders pass for main, OpenShift, dev, and a custom port.