Repository navigation
feat: add OTLP profile forwarding mode - #6459
Merged
Merged
Conversation
Convert scraped pprof profiles with the OpenTelemetry translator and export them over OTLP/gRPC. Preserve target labels as resource attributes and pprof labels as sample attributes, with semantic-convention configuration examples. Amp-Thread-ID: https://ampcode.com/threads/T-01a18c4e-d681-71f4-8158-32d8026e071b Co-authored-by: Amp <amp@ampcode.com>
|
✅ Meticulous spotted 0 visual differences across 14 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit |
metalmatze
approved these changes
Oct 30, 2026
metalmatze
left a comment
metalmatze
left a comment
Member
There was a problem hiding this comment.
let's go.
let's get it in and then do follow ups if we find something.
Amp-Thread-ID: https://ampcode.com/threads/T-01a18c4e-d681-71f4-8158-32d8026e071b Co-authored-by: Amp <amp@ampcode.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--mode=otlp-forwarderto convert scraped pprof profiles with the OpenTelemetry converter and export them to an OTLP-only upstream over gRPC.Target and external labels become resource attributes, while labels inside pprof remain sample attributes, including when their names overlap.
The mode reuses the existing TLS, bearer authentication, and custom gRPC headers, without requiring upstream Parca APIs.
Static-target and Kubernetes examples map discovered metadata to OpenTelemetry semantic-convention attributes.
Verified targeted config, profile-store, scrape, and application tests, targeted race checks,
go vet, and a binary build; the end-to-end test exercises discovery, relabeling, scraping, conversion, authentication, and OTLP export.The repository-pinned formatter has also been applied.
The pinned converter currently rejects sample labels with multiple values; that limitation and a real Collector interoperability smoke test remain follow-up review items.
Full CI results are pending.