Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat!: add /aidd-changelog skill + 4.0.0 release prep #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat!: add /aidd-changelog skill + 4.0.0 release prep #201
Changes from all commits
cf8df2f4c83818d2f1ff7c8e537c885d128bc30cbf2350badFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog types and section order lists contradict each other
Medium Severity
The
TypesOfChangesenum inSKILL.mdand theSection Orderinreferences/guidelines.mddisagree on valid change types.TypesOfChangesincludesSecuritybut omitsBreaking Changes, while theSection OrderincludesBreaking Changesbut omitsSecurity. The scoping rules also reference### Breaking Changesas a valid classification. An AI agent following these contradictory definitions may fail to generateBreaking Changessections (since it's not inTypesOfChanges) or misplaceSecurityentries (since they have no defined position in the ordering). The project's ownCHANGELOG.mdv4.0.0 already uses### Breaking Changes, demonstrating the mismatch.Additional Locations (1)
ai/skills/aidd-changelog/references/guidelines.md#L38-L48Reviewed by Cursor Bugbot for commit c8e537c. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command references nonexistent
/aidd-delegateskillMedium Severity
The
/aidd-pr delegatecommand description says "via/aidd-delegate" but no/aidd-delegateskill exists anywhere in the codebase. The actual implementation in Steps 3–4 correctly uses/aidd-paralleland/aidd-parallel delegate. An agent reading theCommandsblock to understand how to run the delegate subcommand would be pointed to a nonexistent skill.Reviewed by Cursor Bugbot for commit 2350bad. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
import /aidd-rtcin aidd-upskill skillLow Severity
The old
aidd-upskillSKILL.md referencedaidd-pleaseas a skill component (which provided RTC). This PR removed that reference and replaced it with onlyimport ai/skills/aidd-sudolang-syntax, but did not addimport /aidd-rtc. Thereferences/process.mduses/aidd-rtc --compactin both thecreateSkillandreviewSkillpipelines, and every other skill that uses RTC now explicitly imports it.Additional Locations (1)
ai/skills/aidd-upskill/references/process.md#L8-L9Reviewed by Cursor Bugbot for commit 2350bad. Configure here.
Uh oh!
There was an error while loading. Please reload this page.